Skip to content
Snippets Groups Projects
  1. Mar 05, 2021
  2. Mar 04, 2021
  3. Mar 03, 2021
  4. Mar 02, 2021
    • thorstenhater's avatar
      Bug/multiplicity (#1401) · 659e3c37
      thorstenhater authored
      * Fix a quite obvious ptr arithmetic bug.
      
      * Clean-up to avoid similar issues.
      
      * Const, my old friend.
      
      * Test: refactor..
      
      * Lambda capture.
      
      * Clean up using append_chunk.
      
      * Catch two escaped _.
      659e3c37
  5. Mar 01, 2021
  6. Feb 25, 2021
  7. Feb 22, 2021
  8. Feb 19, 2021
    • Sebastian Schmitt's avatar
      Fix typo in docs sample code (#1391) · 0d336d3d
      Sebastian Schmitt authored
      0d336d3d
    • thorstenhater's avatar
      Mech ABI Prelim: Unify Mechanism Interfaces (#1357) · 32ad5a41
      thorstenhater authored
      Preliminary work towards the mechanism ABI.
      
      Unification of the `public` and `protected` interfaces of the mechanism classes.
      These interfaces will be merged into the public API ('public' as in: exposed via `arbor/include/arbor`). 
      
      Interface methods `nrn_` have been renamed
      - `nrn_init`: `init` (would have preferred initialize, but that is taken)
      - `deliver_events(event_stream)`: `apply_events` (to avoid a name clash)
      - `nrn_state`: `advance_state`
      - `nrn_current`: `compute_currents`
      
      Additional changes:
        - Remove typedefs for index_type etc
        - Shuffle `ion_state_view` to public interface
        - Migrate `copy_extend` to a proper place out of `multicore/mechanism.hpp`. Maybe `memory` or `range_util`.
        - Remove `vec_t_to_`
      32ad5a41
    • thorstenhater's avatar
  9. Feb 18, 2021
  10. Feb 17, 2021
  11. Feb 16, 2021
  12. Feb 15, 2021
    • Nora Abi Akar's avatar
      Allow current updates to be non-linear in v (#1374) · a5e90dcc
      Nora Abi Akar authored
      * Remove check for strict linearity in current contribution in modcc, as it is no longer necessary.
      a5e90dcc
    • Sebastian Schmitt's avatar
    • Nora Abi Akar's avatar
      Refactor `algorithms.hpp` (#1354) · 98c6e95a
      Nora Abi Akar authored
      * Refactor the functions from `algorithms.hpp`:
        - `mean`: moved to `profile/meter_manager.cpp`
        - `make_index`: moved to `util/index.hpp`
        - `is_strictly_monotonic_increasing`: moved to `/backends/gpu/forest.hpp`
        - `has_contiguous_compartments`:  moved to `/backends/gpu/forest.hpp`.
        - `branches`: moved to `/backends/gpu/forest.hpp`.
        - `expand_branches`: moved to `/backends/gpu/forest.hpp`.
        - `tree_reduce`: moved to `/backends/gpu/forest.hpp`.
        - `is_minimal_degree`: moved to `tree.hpp`.
        - `child_count`: moved to `tree.hpp`.
        - `in_interval`: not used, deleted.
        - `is_strictly_monotonic_decreasing`: not used, deleted.
        - `all_positive`:  not used, deleted.
        - `all_negative`: not used, deleted.
        - `find_branch`: not used, deleted.
        - `is_unique`: not used, deleted.
        - `binary_find`: not used, deleted.
      * Remove `make_parent_index` from `tree.hpp`: not used. 
      * Replace `make_index` usages with `make_partition`.
      * Add unit tests to `test_forest.cpp`, `test_tree.cpp` and `test_index.cpp`.
      98c6e95a
    • thorstenhater's avatar
      Add modcc. (#1377) · 88fd791d
      thorstenhater authored
      88fd791d
    • thorstenhater's avatar
      Make `pas/e` GLOBAL instead of RANGE (#1372) · 95b38462
      thorstenhater authored
      - Make reversal potential `e` a global parameter of `pas` to avoid inconsistency 
        (reversal potential is represented by a RANGE parameter, despite it not being a conductance multiplier see #1052)
      - Adjust default value of `e` to -70mV (as in Neuron)
      - Streamline docs,  which use `passive`, `el`, and `gl` instead of `passive`, `e`, and `g`.
      
      Closes #1052
      95b38462
    • Harmen Stoppels's avatar
      Fixes for codecov (#1370) · 89fda19d
      Harmen Stoppels authored
      - remove repeated CMAKE_BUILD_TYPE
      - bump lcov to 1.15
      - use new --exclude flag to skip generated sources
      
      With gcc 8 as a compiler + a new version of lcov (#1350) codecov started tracking generated source files and coverage dropped to < 60%. Not sure if this is a bug in lcov or not. I've added these new flags for lcov: `--exclude "*/ext/*" --exclude "*/test/*" --exclude "*/mechanisms/*"` to fix it.
      89fda19d
    • thorstenhater's avatar
      Workaround for MacOS+OpenMPI4 (#1375) · e4aa3d32
      thorstenhater authored
      Use TCP BTL for MPI in GitHub Actions to fix sporadic SEGFAULT on MacOS.
      
      See open-mpi/ompi#6518
      e4aa3d32
  13. Feb 12, 2021
  14. Feb 11, 2021
    • Brent Huisman's avatar
      Docs reorder cable cell (#1310) · c96ef921
      Brent Huisman authored
      * Sync Cable Cell page names and ordering between sections (concept, python, cpp). Except cpp cable cell page. Is still one big page.
      * Move CV definition across categories to consistent location.
      * Move decor to separate page (cpp currently missing decor documentation) because it's a top-level concept that should be in the TOC like the other ingredients of the cable cell.
      * Slight rework of Concept intro and Cable Cell pages.
      * The Cable Cell page is now basically an intro, and lay out how the other pages/concepts relate to each other.
      c96ef921
    • Sebastian Schmitt's avatar
      Example for a plastic synapse (#1345) · fc5e98ba
      Sebastian Schmitt authored
      Online STDP is implemented in the synapse and
      and demonstrated by recording an STDP curve in
      an example.
      fc5e98ba
    • Nora Abi Akar's avatar
      Modcc: comments & seg fault (#1360) · 2775b3f3
      Nora Abi Akar authored
      * fix nmodl comment parsing
      * proper handling of \r
      * fix segmentation fault when api_state is null
      * add unit tests
      2775b3f3
    • Nora Abi Akar's avatar
      Modcc: parse the unit of `FUNCTION` (#1361) · 89a2f041
      Nora Abi Akar authored
      * add function unit parsing
      * add unit tests
      89a2f041
    • Nora Abi Akar's avatar
      update gitpod cmake (#1363) · 2adcd65c
      Nora Abi Akar authored
      2adcd65c
  15. Feb 10, 2021
  16. Feb 09, 2021
  17. Feb 08, 2021
  18. Feb 06, 2021
    • Nora Abi Akar's avatar
      Use JFrog as a registry and fix build errors (#1350) · e5123942
      Nora Abi Akar authored
      * Make Gitlab CI push images to CSCS' JFrog registry reg.giuv.cscs.ch so that sarus can pull images on Daint again. 
        This URL is probably temporary until JFrog officially goes into production later this month.
        Unfortunately JFrog is currently behind the firewall.
      * Upgrade g++ to g++8 on the Docker image.
      * Only require libxml when compiling with NeuroML support.
      e5123942
  19. Feb 05, 2021