Skip to content
Snippets Groups Projects
  1. Oct 04, 2018
    • Benjamin Cumming's avatar
      Extend ring (#611) · 488ece0c
      Benjamin Cumming authored
      Extend the ring benchmark to have an optional number of synapses attached to each cell, instead of a fixed count of one synapse per cell.
      This doesn't change the behavior of the model: only the first synapse is used for communication. The other synapses only effect is to
      increase the per-cell computational overheads, to more effectively mimic real world performance.
  2. Oct 03, 2018
  3. Oct 01, 2018
    • noraabiakar's avatar
      Add CMake options for V100 support (#608) · 2334ada8
      noraabiakar authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Add CMake options for V100 support. fixes #605
      2334ada8
    • noraabiakar's avatar
      Fix GPU installation (#607) · 9129b2eb
      noraabiakar authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Updates the install docs. Fixes #604
      9129b2eb
    • akuesters's avatar
      Integrating Mac OS X and clang compiler into Travis CI (#601) · e755a420
      akuesters authored and Benjamin Cumming's avatar Benjamin Cumming committed
      changes: 
      - .travis.yml:
        - added matrix for different osx's, since enumeration style only works for `env` and `compiler`
      
      - scripts/travis/build.sh:
        - changed getting compiler version from ``${CXX} -dumpversion`` to ``${CXX} --version | grep -m1 ""`` 
        - added `--oversubscribe` flag to `mpiexec` on Mac to allow more processes on a node than processing elements
        - added `--mca btl tcp,self` flag for Open MPI to use the "tcp" and "self" BTLs for transporting MPI messages on Mac
      e755a420
    • Sam Yates's avatar
      Fix double throw of captured exception in thread group. (#606) · d6aec81a
      Sam Yates authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Fixes #603.
      
      * Clear exception pointer in exception_state helper class after move of state.
      * Rename exception_state::get() method to reset().
      * Call std::terminate() if task_group is destroyed before tasks are collected with wait().
      * Do not attempt to collect tasks in destructor for task_group.
      * Do not attempt to rethrow exception in destructor for exception_state.
      * Add unit test to verify correct exception behaviour when a task_group is runs and waits on a series of tasks.
      * Add unit test for terminate behaviour as above.
      
      Code quality fix ups:
      * Remove unused warning variable warning in threading exception tests.
      * Address if-statement spacing in threading.hpp.
      * Use ARB_HAVE_MPI in execution_context.cpp instead of introducing a dependency on generated version header via feature macro ARB_MPI_ENABLED.
      d6aec81a
  4. Sep 26, 2018
    • noraabiakar's avatar
      Threading exceptions (#595) · b5662870
      noraabiakar authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Propagate exceptions generated in `task_group` tasks on different threads in the threading backend, so that they are thrown on the main thread on `task_group.wait()`.
      
      Add tests that verify that exceptions are propagated correctly.
      
      Fixes #310.
      b5662870
  5. Sep 19, 2018
  6. Sep 18, 2018
  7. Sep 17, 2018
    • noraabiakar's avatar
      Dry-run mode (#582) · a2b39382
      noraabiakar authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Dry-run mode: 
      * An implementation of distributed_context that is used to mimic the performance of running an MPI distributed simulation with n ranks.
      * Verifiable against an MPI run with the same parameters. 
      
      Implementation: 
      * Describe the model on a single domain (tile) and translate it to however many domains we want to mimic using arb::tile and arb::symmetric_recipe. This allows us to know the exact behavior of the entire system by only running the simulation on a single node.
      * Mimic communication between domains using arb::dry_run_context
      
      Example: 
      * dryrun in example/ is a verifiable example of using dry-run mode with mc_cells
      
      Other:
      * Documentation of dry-run mode 
      * unit test for dry_run_context 
      a2b39382
  8. Sep 07, 2018
  9. Sep 06, 2018
    • Sam Yates's avatar
      Clarify vectorization-enabled build errors. (#588) · 1ffccf2d
      Sam Yates authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Fixes #587.
      
      * Eliminate Clang warnings from GCC-tree-optimization bug work-around.
      * Error with static-assert if simd type is used with a missing simd abi.
      * Clarify install documentation regarding use of ARB_VECTORIZE with ARB_ARCH.
      1ffccf2d
  10. Sep 05, 2018
  11. Sep 01, 2018
  12. Aug 30, 2018
    • Benjamin Cumming's avatar
      Opaque Public Context (#576) · d637c8bc
      Benjamin Cumming authored
      Make the execution context presented to users an opaque handle, moving all implementation of the gpu, thread and distributed contexts into the back end.
      
      * move `execution_context` and `distributed_context` definitions to the back end
      * create `execution_context` handle called `context` in the public API
      * provide `make_context` helper functions that build different context configurations (default, user-specified local resources, with MPI)
      * update documentation for all parts of the public API that touch contexts
      * move `distributed_context` docs to the developer documentation (from the public API docs)
  13. Aug 29, 2018
  14. Aug 24, 2018
  15. Aug 22, 2018
  16. Aug 20, 2018
    • Sam Yates's avatar
      Global temperature for NMODL mechanisms. (#565) · fa0d7aef
      Sam Yates authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Global temperature for mechanisms.
      
      * Make 'celsius' magic in modcc: now an indexed variable.
      * Add a new temperature data source for indexed variables.
      * Add support to printers for indexed variables that reference a scalar.
      * Check that indexed variables aren't used in PROCEDURE blocks (this is a problem not just for 'celsius').
      * Modify built-in mod files to pass celsius as a parameter to rates() procedures.
      * Add global temperature to shared_state classes, and initialize through backend mechanism superclasses.
      * Add some infrastructure for unit-test only mechanisms.
      * Set modcc flags globally in top level CMakeLists.txt.
      * Add test mechanism/module for checking celsius setting.
      * Add unit test for multicore and gpu mechanism celsius setting.
      * Make common mechanism private field data access helper for unit tests.
      * Use helper in temperature, synapses tests.
      * Fix warning in `distribued_context.hpp` about errant semicolon.
      * Fix global scal...
      fa0d7aef
  17. Aug 06, 2018
    • Sam Yates's avatar
      Bugfix/build osx macports (#563) · 3bafa1b3
      Sam Yates authored
      Two MacPorts/gcc7 issues:
      
      std::uint64_t is unsigned long long on OS X, breaking an assumption about size_t in the distributed_context interface.
      Problems with missing errno defines in the standard library headers.
      With MacPorts gcc7, the installed c++config.h defines _GLIBCXX_HAVE_EOWNERDEAD and _GLIBCXX_HAVE_ENOTRECOVERABLE, but the corresponding errno defines are not provided by
      sys/errno.h unless __DARWIN_C_SOURCE, which takes its value from _POSIX_C_SOURCE if defined, is greater than or equal to 200809L. Technically a MacPorts configuration bug? but easily worked around.
      
      Use basic integral types for communication collectives interfaces.
      Define _POSIX_C_SOURCE to be 200809L for glob.cpp.
      Fixes #562.
      3bafa1b3
  18. Jul 31, 2018
    • Sam Yates's avatar
      Split multi_event_stream.cu implementation. (#556) · ac581c6b
      Sam Yates authored
      * Remove dependency on memory library and range utils from `multi_event_stream.cu` source.
      
      Fixes #545
    • noraabiakar's avatar
      Manage distributed_context using shared pointers (#555) · 0d6b365a
      noraabiakar authored and Sam Yates's avatar Sam Yates committed
      * Replace distributed_contest with shared_ptr<distributed_context> in execution_context and pass around the shared pointer instead of a raw pointer.
      * Fix construction of mpi_context
      * Remove num_threads() from arb and arb::threading. Modify mpi_context so it also returns a shared_ptr. proc_allocation is initialized from execution context to determine available resources.
      * Rename threading backend files. Delete useless files.
      * Pass execution_context by const reference or value.
      * Remove code duplication in thread_system constructors.
      0d6b365a
  19. Jul 26, 2018
    • Sam Yates's avatar
      Update install docs for architecture build options. (#489) · 845077e6
      Sam Yates authored and Benjamin Cumming's avatar Benjamin Cumming committed
      * Update the install docs for architecture build options
      * Update to reflect new install target
      845077e6
    • Sam Yates's avatar
      Return view from schedule, replace time_seq. (#536) · 0d20df25
      Sam Yates authored
      Reduce redundant functionality across event_generator, time_seq
      and schedule by providing a low-heap overhead interface to schedule
      and using that for time sequences in event_generator and specialized
      cell groups.
      
      * Have schedule return pair of pointers as view to generated times.
      * Fix missing DEBUG/TRACE functionality.
      * Use rate instead of mean_dt for Poisson schedule.
      * Move merge_events() functionality to simulator.cpp.
      * Migrate event_generator to event span interface.
      * Migrate tourney_tree to event span interface.
      * Only invoke tourney_tree merge if generators have events in the epoch.
      * Use schedule for times in event_generator implementations.
      * Replace seq_generator with explicit_generator that keeps a copy of events.
      * Replace vector_backed_generator and poisson_generator with schedule_generator.
      * Replace time_seq uses with schedule.
      * Add default empty schedule.
      * Move rounding error test for regular time sequence into sch...
    • noraabiakar's avatar
      Use correct profiling flag (#549) · 487a65e9
      noraabiakar authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Use correct profiling and mpi flags.
      Fix profiler doc
      487a65e9
  20. Jul 25, 2018
    • Benjamin Cumming's avatar
      Remove `memory::array` from `arb::tree` (#547) · af5fe62a
      Benjamin Cumming authored
      This small refactor simplifies the interface and implementation of the `tree` type.
      * use `std::vector` instead of `memory::array` for internal storage in `arb::tree`
      * return a `util::range` intstead of a view for `tree::children(int)`
      * remove unused functionality for changing the root of a tree.
    • noraabiakar's avatar
      fix profiler (#548) · 177cce0d
      noraabiakar authored and Benjamin Cumming's avatar Benjamin Cumming committed
      Add initialize method to the profiler to set up the needed threading parameters given a simulation's task system.
      177cce0d
  21. Jul 24, 2018
    • noraabiakar's avatar
      task_system as part of an execution_context (#537) · 7a6c1031
      noraabiakar authored and Benjamin Cumming's avatar Benjamin Cumming committed
      - Task system is no longer a single system private to the implementation of the threading backend and used everywhere. A separate task_system can be used (with a specified number of threads) for every simulation.
      - arb::execution_context is the interface to task_system  and the previously defined distributed_context
      - TBB and serial support has been removed. Cthreads is the only threading backend available. 
      7a6c1031
  22. Jul 20, 2018
  23. Jul 19, 2018
    • noraabiakar's avatar
      Cthreads: implement task queue per thread with task stealing (#528) · 4d63988a
      noraabiakar authored and Sam Yates's avatar Sam Yates committed
      Cthreads classes:
      - Notification queue : Manages tasks: tries or forces popping and pushing tasks.  
      - Task system : manages the notifications queues; controls which queue to pop from/push to; controls spinning on queues if necessary; manages creating/joining threads. Is a singleton.
      - Task group : manages synchronization on a group of tasks. 
      
      Operation: 
      - Each thread has an associated queue
      - Task system _tries to_ push tasks in one of the available queues. If it is unable to acquire a lock on a queue, it tries the next in a round robin fashion. After it loops all queues if it still hasn't successfully pushed the task, it spins on a single queue until lock is acquired and task is pushed. 
      - Task system _tries to_ pop a task from the calling thread's queue. If it is unable to acquire the lock, it tries to steal the task from another thread's queue, in a round robin loop. If it is still unable to pop a task, it spins on its the c...
      4d63988a
  24. Jul 13, 2018