housekeeping

src/atlasViewer/atlasViewer.component.ts

@@ -332,6 +332,9 @@ export class AtlasViewer implements OnDestroy, OnInit, AfterViewInit {
     this.pluginService.appendSrc = (src: HTMLElement) => this.rd2.appendChild(document.head, src)
   }
 
+  /**
+   * perhaps move this to constructor?
+   */
   meetsRequirements() {
 
     const canvas = document.createElement('canvas')
@@ -386,13 +389,6 @@ export class AtlasViewer implements OnDestroy, OnInit, AfterViewInit {
     }) as NgLayerInterface)
   }
 
-  /* obsolete soon */
-  manualPanelToggle(show: boolean) {
-    this.store.dispatch({
-      type: show ? OPEN_SIDE_PANEL : CLOSE_SIDE_PANEL
-    })
-  }
-
   rafId : number | null
 
   panelAnimationFlag(flag:boolean){
@@ -411,12 +407,6 @@ export class AtlasViewer implements OnDestroy, OnInit, AfterViewInit {
     }
   }
 
-  // clearDedicatedView() {
-  //   this.store.dispatch({
-  //     type: UNLOAD_DEDICATED_LAYER
-  //   })
-  // }
-
   toggleSidePanel(panelName:string){
     this.store.dispatch({
       type : TOGGLE_SIDE_PANEL,

src/atlasViewer/atlasViewer.template.html

@@ -3,8 +3,7 @@
   <layout-mainside
     [showSide] = "false"
     [overlay] = "false"
-    (panelAnimationFlag) = "panelAnimationFlag($event)"
-    (panelShowStateChanged) = "manualPanelToggle($event)">
+    (panelAnimationFlag) = "panelAnimationFlag($event)">
     <div maincontent>
       <ui-nehuba-container>
       </ui-nehuba-container>

src/atlasViewer/atlasViewer.urlService.service.ts

@@ -35,6 +35,7 @@ export class AtlasViewerURLService{
       scan((acc,val)=>Object.assign({},acc,val),{})
     )
 
+    /* services has no ngOnInit lifecycle */
     this.subscriptions()
   }
 
@@ -92,6 +93,7 @@ export class AtlasViewerURLService{
         })
       }
 
+      /* TODO deprecated. keep for backwards compatiblity? */
       const dedicatedView = searchparams.get('dedicatedView')
       if(dedicatedView){
         this.store.dispatch({
@@ -136,6 +138,7 @@ export class AtlasViewerURLService{
                 _[key] = state[key]
             }
           }else{
+            /* TODO dedicatedView is decprecated */
             if(key === 'dedicatedView'){
               _[key] = null
             }