diff --git a/src/atlasViewer/atlasViewer.component.ts b/src/atlasViewer/atlasViewer.component.ts index 95e78c5deacdae28c9424407aefefdabb27d3772..79d55084085ba2236693781acd63184bf070e6c7 100644 --- a/src/atlasViewer/atlasViewer.component.ts +++ b/src/atlasViewer/atlasViewer.component.ts @@ -332,6 +332,9 @@ export class AtlasViewer implements OnDestroy, OnInit, AfterViewInit { this.pluginService.appendSrc = (src: HTMLElement) => this.rd2.appendChild(document.head, src) } + /** + * perhaps move this to constructor? + */ meetsRequirements() { const canvas = document.createElement('canvas') @@ -386,13 +389,6 @@ export class AtlasViewer implements OnDestroy, OnInit, AfterViewInit { }) as NgLayerInterface) } - /* obsolete soon */ - manualPanelToggle(show: boolean) { - this.store.dispatch({ - type: show ? OPEN_SIDE_PANEL : CLOSE_SIDE_PANEL - }) - } - rafId : number | null panelAnimationFlag(flag:boolean){ @@ -411,12 +407,6 @@ export class AtlasViewer implements OnDestroy, OnInit, AfterViewInit { } } - // clearDedicatedView() { - // this.store.dispatch({ - // type: UNLOAD_DEDICATED_LAYER - // }) - // } - toggleSidePanel(panelName:string){ this.store.dispatch({ type : TOGGLE_SIDE_PANEL, diff --git a/src/atlasViewer/atlasViewer.template.html b/src/atlasViewer/atlasViewer.template.html index a535fe1d897b31046ea3663b2d61cfadb9f1a2e4..6d515896981614f602f5ee080da21c2808ea7d65 100644 --- a/src/atlasViewer/atlasViewer.template.html +++ b/src/atlasViewer/atlasViewer.template.html @@ -3,8 +3,7 @@ <layout-mainside [showSide] = "false" [overlay] = "false" - (panelAnimationFlag) = "panelAnimationFlag($event)" - (panelShowStateChanged) = "manualPanelToggle($event)"> + (panelAnimationFlag) = "panelAnimationFlag($event)"> <div maincontent> <ui-nehuba-container> </ui-nehuba-container> diff --git a/src/atlasViewer/atlasViewer.urlService.service.ts b/src/atlasViewer/atlasViewer.urlService.service.ts index 06adbdda4246c2a176752f37973d6556b659d66d..910f4d33aedd28672be593a8b64e7eba9e968c81 100644 --- a/src/atlasViewer/atlasViewer.urlService.service.ts +++ b/src/atlasViewer/atlasViewer.urlService.service.ts @@ -35,6 +35,7 @@ export class AtlasViewerURLService{ scan((acc,val)=>Object.assign({},acc,val),{}) ) + /* services has no ngOnInit lifecycle */ this.subscriptions() } @@ -92,6 +93,7 @@ export class AtlasViewerURLService{ }) } + /* TODO deprecated. keep for backwards compatiblity? */ const dedicatedView = searchparams.get('dedicatedView') if(dedicatedView){ this.store.dispatch({ @@ -136,6 +138,7 @@ export class AtlasViewerURLService{ _[key] = state[key] } }else{ + /* TODO dedicatedView is decprecated */ if(key === 'dedicatedView'){ _[key] = null }