Remove generic event interface on cell_group
`cell_group` had a template method `cell_group::enqueue_events()`, which was parameterized on the type of container used to pass the set of events to enqueue. This PR removes the template, and makes `time_type` a globally defined type in `common_types.hpp`. The `time_type` that permeated the code is taken from `spike`, which is itself a specialized type alias of `basic_spike`. This is not an intuitive location to define the `time_type`, and hides the fact that as implemented it was effectively a global typedef. * Define the default time type in `common_types.hpp`: `using time_type = float`. * Use this global `time_type` in the definition of `spike` and `postsynaptic_spike_event`. * Replace generic `cell_group::enqueue_events` method with concrete `cell_group::enque_events(const std::vector<post_synaptic_event>&)`.
Showing
- miniapp/miniapp.cpp 2 additions, 2 deletionsminiapp/miniapp.cpp
- src/cell_group.hpp 6 additions, 8 deletionssrc/cell_group.hpp
- src/common_types.hpp 4 additions, 0 deletionssrc/common_types.hpp
- src/communication/communicator.hpp 2 additions, 2 deletionssrc/communication/communicator.hpp
- src/connection.hpp 1 addition, 3 deletionssrc/connection.hpp
- src/event_binner.cpp 2 additions, 3 deletionssrc/event_binner.cpp
- src/event_binner.hpp 0 additions, 2 deletionssrc/event_binner.hpp
- src/event_queue.hpp 6 additions, 11 deletionssrc/event_queue.hpp
- src/model.hpp 0 additions, 1 deletionsrc/model.hpp
- src/spike.hpp 6 additions, 7 deletionssrc/spike.hpp
- tests/unit/test_event_queue.cpp 3 additions, 3 deletionstests/unit/test_event_queue.cpp
- tests/validation/validate_synapses.hpp 1 addition, 1 deletiontests/validation/validate_synapses.hpp
Please register or sign in to comment