Extents don't include the cover of fork points by default. (#998)
This PR removes the requirement that all cover points are included in a region. The motivation is to allow more flexible definion of regions, particularly the proximal and distal sets thereof. The other motivation is that the author finds it much simpler to reason about, however others find the existing approach easier to reason about. The changes: * `mextent` does not always include points on the cover at fork points. * it still enforces that its constituent cables have no intersections and are ordered. * a `super` region expression adds the cover points to a region. * update `most_proximal` to return the `minset` of the proximal points in a region's cables. * fix some cut and paste errors in comments and printing of locset expressions.
Showing
- arbor/include/arbor/morph/morphology.hpp 14 additions, 14 deletionsarbor/include/arbor/morph/morphology.hpp
- arbor/include/arbor/morph/region.hpp 3 additions, 0 deletionsarbor/include/arbor/morph/region.hpp
- arbor/morph/locset.cpp 12 additions, 8 deletionsarbor/morph/locset.cpp
- arbor/morph/morphology.cpp 8 additions, 95 deletionsarbor/morph/morphology.cpp
- arbor/morph/region.cpp 77 additions, 8 deletionsarbor/morph/region.cpp
- python/cells.cpp 1 addition, 1 deletionpython/cells.cpp
- test/unit/test_cv_geom.cpp 17 additions, 8 deletionstest/unit/test_cv_geom.cpp
- test/unit/test_morph_expr.cpp 60 additions, 50 deletionstest/unit/test_morph_expr.cpp
- test/unit/test_morphology.cpp 24 additions, 65 deletionstest/unit/test_morphology.cpp
Please register or sign in to comment