Add phase parameter to current clamps. (#1474)
* `i_clamp` constructors take new optional phase argument. * Pulse or box envelope clamps are now provided by the static method `i_clamp::box`, taking onset, duration, and amplitude parameters. * Bump pybind11 version so we can have keyword-only arguments in the Python API. * Make frequency and phase keyword-only arguments to Python `iclamp`. * Change frequency units for clamps from Hz to kHz for consistency with other interfaces. Fixes #1454.
Showing
- arbor/backends/gpu/shared_state.cpp 2 additions, 0 deletionsarbor/backends/gpu/shared_state.cpp
- arbor/backends/gpu/shared_state.hpp 2 additions, 1 deletionarbor/backends/gpu/shared_state.hpp
- arbor/backends/gpu/stimulus.cu 2 additions, 2 deletionsarbor/backends/gpu/stimulus.cu
- arbor/backends/gpu/stimulus.hpp 1 addition, 0 deletionsarbor/backends/gpu/stimulus.hpp
- arbor/backends/multicore/shared_state.cpp 4 additions, 3 deletionsarbor/backends/multicore/shared_state.cpp
- arbor/backends/multicore/shared_state.hpp 2 additions, 1 deletionarbor/backends/multicore/shared_state.hpp
- arbor/fvm_layout.cpp 3 additions, 0 deletionsarbor/fvm_layout.cpp
- arbor/fvm_layout.hpp 2 additions, 1 deletionarbor/fvm_layout.hpp
- arbor/include/arbor/cable_cell_param.hpp 12 additions, 7 deletionsarbor/include/arbor/cable_cell_param.hpp
- arborio/cableio.cpp 10 additions, 10 deletionsarborio/cableio.cpp
- doc/concepts/decor.rst 8 additions, 7 deletionsdoc/concepts/decor.rst
- doc/fileformat/cable_cell.rst 13 additions, 13 deletionsdoc/fileformat/cable_cell.rst
- doc/python/decor.rst 1 addition, 1 deletiondoc/python/decor.rst
- example/gap_junctions/gap_junctions.cpp 1 addition, 1 deletionexample/gap_junctions/gap_junctions.cpp
- example/probe-demo/probe-demo.cpp 1 addition, 1 deletionexample/probe-demo/probe-demo.cpp
- python/cells.cpp 11 additions, 9 deletionspython/cells.cpp
- python/pybind11 1 addition, 1 deletionpython/pybind11
- test/unit/test_fvm_lowered.cpp 6 additions, 5 deletionstest/unit/test_fvm_lowered.cpp
- test/unit/test_mc_cell_group.cpp 1 addition, 1 deletiontest/unit/test_mc_cell_group.cpp
- test/unit/test_mc_cell_group_gpu.cpp 1 addition, 1 deletiontest/unit/test_mc_cell_group_gpu.cpp
Please register or sign in to comment