Skip to content
Snippets Groups Projects

Fix issues raised by golosio

Merged Fix issues raised by golosio
github/fork/AlexVanMeegen/fix_golosio_issues into master
Merged Didi Hou requested to merge github/fork/AlexVanMeegen/fix_golosio_issues into master

Created by: AlexVanMeegen

Various fixes for the issues raised by @golosio in #21 (closed) and #22 (closed) and some additional minor fixes:

  • add pytest to the requirements
  • fix the SIM_LABELS access in figures/Schmidt2018_dyn/Snakefile (see #22 (closed))
  • fix division by zero errors in analysis_helpers.py (see #21 (closed))
  • fix default value of K_stable (see #21 (closed))

@jarsi, could you have a quick look?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Didi Hou
    Didi Hou @didihou ·
    Author Owner

    Created by: jarsi

    Review: Commented

    Thanks for tackling these issues :fire:

    It all looks good, one point might need discussion.

  • Didi Hou
    Didi Hou @didihou ·
    Author Owner

    Created by: AlexVanMeegen

    Addressed your concern, @jarsi. Please merge if you deem it appropriate.

  • Didi Hou
    Didi Hou @didihou ·
    Author Owner

    Merged by: jarsi at 2020-12-03 18:13:48 UTC

  • Didi Hou merged manually

    merged manually

  • Didi Hou closed

    closed

  • Didi Hou
    Didi Hou @didihou ·
    Author Owner

    Created by: jarsi

    Thanks for the work, merged.

  • Didi Hou
    Didi Hou @didihou ·
    Author Owner

    Created by: AlexVanMeegen

    Thanks for reviewing!

    • Please register or sign in to reply