Skip to content
Snippets Groups Projects
Unverified Commit f143be26 authored by xgui3783's avatar xgui3783 Committed by GitHub
Browse files

Merge pull request #521 from HumanBrainProject/bug_fix_520_region_menu_title_staus

Fix #520 - region menu title dataset status
parents de7dd665 aca4d1bf
No related branches found
No related tags found
No related merge requests found
...@@ -10,6 +10,17 @@ const dict = { ...@@ -10,6 +10,17 @@ const dict = {
} }
] ]
} }
},
"Big Brain (Histology)": {
"Cytoarchitectonic Maps": {
tests:[
{
position: [440,200],
expectedLabelName: 'Area hOc1 (V1, 17, CalcS)',
expectedLabelStatus: '(fully mapped)'
}
]
}
} }
} }
...@@ -41,6 +52,26 @@ describe('> viewerCtxMenu', () => { ...@@ -41,6 +52,26 @@ describe('> viewerCtxMenu', () => {
expect(visible).toBeTrue() expect(visible).toBeTrue()
}) })
it('> Title includes region status', async () => {
const { tests } = dict[templateName][parcellationName]
const { expectedLabelStatus, expectedLabelName } = tests[0]
await iavPage.wait(500)
if (expectedLabelStatus) {
const fullMenuText = await iavPage.getText(`[aria-label="${ARIA_LABELS.CONTEXT_MENU}"]`)
expect(fullMenuText.includes(`${expectedLabelName} ${expectedLabelStatus}`)).toEqual(true)
}
})
it('> Title do not includes region status', async () => {
const { tests } = dict[templateName][parcellationName]
const { expectedLabelStatus, expectedLabelName } = tests[0]
await iavPage.wait(500)
if (!expectedLabelStatus) {
const fullMenuText = await iavPage.getText(`[aria-label="${ARIA_LABELS.CONTEXT_MENU}"]`)
expect(fullMenuText.includes(expectedLabelName)).toEqual(true)
}
})
it('> pos does not change when click inside', async () => { it('> pos does not change when click inside', async () => {
const { x: xBefore, y: yBefore, height: hBefore } = await iavPage.isAt(`[aria-label="${ARIA_LABELS.CONTEXT_MENU}"]`) const { x: xBefore, y: yBefore, height: hBefore } = await iavPage.isAt(`[aria-label="${ARIA_LABELS.CONTEXT_MENU}"]`)
await iavPage.click(`[aria-label="${ARIA_LABELS.SHOW_IN_OTHER_REF_SPACE}"]`) await iavPage.click(`[aria-label="${ARIA_LABELS.SHOW_IN_OTHER_REF_SPACE}"]`)
...@@ -60,4 +91,4 @@ describe('> viewerCtxMenu', () => { ...@@ -60,4 +91,4 @@ describe('> viewerCtxMenu', () => {
}) })
} }
} }
}) })
\ No newline at end of file
...@@ -2,6 +2,7 @@ ...@@ -2,6 +2,7 @@
<mat-card-title> <mat-card-title>
<div class="position-relative region-name"> <div class="position-relative region-name">
{{ region.name }} {{ region.name }}
<small *ngIf="region.status"> ({{region.status}})</small>
</div> </div>
</mat-card-title> </mat-card-title>
<mat-card-subtitle> <mat-card-subtitle>
...@@ -10,12 +11,12 @@ ...@@ -10,12 +11,12 @@
Brain region Brain region
</span> </span>
</mat-card-subtitle> </mat-card-subtitle>
<mat-card-content> <mat-card-content>
<mat-divider></mat-divider> <mat-divider></mat-divider>
<ng-template #safeHarbour> <ng-template #safeHarbour>
<!-- enlarged region actions --> <!-- enlarged region actions -->
<mat-grid-list cols="2" rowHeight="6rem" gutterSize="0px"> <mat-grid-list cols="2" rowHeight="6rem" gutterSize="0px">
...@@ -29,7 +30,7 @@ ...@@ -29,7 +30,7 @@
<span iav-v-button-text>Select</span> <span iav-v-button-text>Select</span>
</iav-v-button> </iav-v-button>
</mat-grid-tile> </mat-grid-tile>
<mat-grid-tile> <mat-grid-tile>
<iav-v-button <iav-v-button
class="h-100 w-100" class="h-100 w-100"
...@@ -39,7 +40,7 @@ ...@@ -39,7 +40,7 @@
<span iav-v-button-text>Navigate</span> <span iav-v-button-text>Navigate</span>
</iav-v-button> </iav-v-button>
</mat-grid-tile> </mat-grid-tile>
<ng-container *ngFor="let originDataset of (region.originDatasets || [])"> <ng-container *ngFor="let originDataset of (region.originDatasets || [])">
<mat-grid-tile class="iv-custom-comp"> <mat-grid-tile class="iv-custom-comp">
<iav-v-button <iav-v-button
...@@ -53,8 +54,8 @@ ...@@ -53,8 +54,8 @@
<span iav-v-button-text [class]="previewDirective.active ? 'iv-custom-comp primary' : ''">Probability Map {{ previewDirective.active }}</span> <span iav-v-button-text [class]="previewDirective.active ? 'iv-custom-comp primary' : ''">Probability Map {{ previewDirective.active }}</span>
</iav-v-button> </iav-v-button>
</mat-grid-tile> </mat-grid-tile>
</ng-container> </ng-container>
<mat-grid-tile> <mat-grid-tile>
<iav-v-button *ngIf="hasConnectivity" <iav-v-button *ngIf="hasConnectivity"
class="h-100 w-100" class="h-100 w-100"
...@@ -69,7 +70,7 @@ ...@@ -69,7 +70,7 @@
<i class="fas fa-chevron-down" iav-v-button-footer></i> <i class="fas fa-chevron-down" iav-v-button-footer></i>
</iav-v-button> </iav-v-button>
</mat-grid-tile> </mat-grid-tile>
<mat-grid-tile> <mat-grid-tile>
<iav-v-button *ngIf="sameRegionTemplate.length" <iav-v-button *ngIf="sameRegionTemplate.length"
class="h-100 w-100" class="h-100 w-100"
...@@ -83,7 +84,7 @@ ...@@ -83,7 +84,7 @@
<span iav-v-button-text>Change template</span> <span iav-v-button-text>Change template</span>
<i class="fas fa-chevron-down" iav-v-button-footer></i> <i class="fas fa-chevron-down" iav-v-button-footer></i>
</iav-v-button> </iav-v-button>
</mat-grid-tile> </mat-grid-tile>
</mat-grid-list> </mat-grid-list>
</ng-template> </ng-template>
...@@ -110,7 +111,7 @@ ...@@ -110,7 +111,7 @@
Select Select
</div> </div>
</mat-list-item> </mat-list-item>
<!-- position --> <!-- position -->
<mat-list-item *ngIf="region?.position" (click)="navigateToRegion()" mat-ripple> <mat-list-item *ngIf="region?.position" (click)="navigateToRegion()" mat-ripple>
<mat-icon scaled-down fontSet="fas" fontIcon="fa-map-marked-alt" mat-list-icon></mat-icon> <mat-icon scaled-down fontSet="fas" fontIcon="fa-map-marked-alt" mat-list-icon></mat-icon>
...@@ -154,7 +155,7 @@ ...@@ -154,7 +155,7 @@
</div> </div>
<mat-icon fontSet="fas" [fontIcon]="connectivitySwitch.switchState ? 'fa-chevron-up' : 'fa-chevron-down'"></mat-icon> <mat-icon fontSet="fas" [fontIcon]="connectivitySwitch.switchState ? 'fa-chevron-up' : 'fa-chevron-down'"></mat-icon>
</mat-list-item> </mat-list-item>
<!-- connectivity --> <!-- connectivity -->
<mat-list-item *ngIf="connectivitySwitch.switchState" mat-ripple (click)="showConnectivity(region.name)"> <mat-list-item *ngIf="connectivitySwitch.switchState" mat-ripple (click)="showConnectivity(region.name)">
<mat-icon fontSet="fas" fontIcon="fa-none" mat-list-icon></mat-icon> <mat-icon fontSet="fas" fontIcon="fa-none" mat-list-icon></mat-icon>
...@@ -196,7 +197,7 @@ ...@@ -196,7 +197,7 @@
</div> </div>
</mat-list-item> </mat-list-item>
</div> </div>
</div> </div>
</mat-list> </mat-list>
</mat-card-content> </mat-card-content>
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment