Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
siibra-explorer
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Xiao Gui
siibra-explorer
Commits
97efb4ae
Commit
97efb4ae
authored
4 years ago
by
Xiao Gui
Browse files
Options
Downloads
Patches
Plain Diff
bugfix: plState when template not selected
parent
335a1f61
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
deploy/bkwdCompat/urlState.js
+5
-0
5 additions, 0 deletions
deploy/bkwdCompat/urlState.js
e2e/src/advanced/urlParsing.prod.e2e-spec.js
+17
-0
17 additions, 0 deletions
e2e/src/advanced/urlParsing.prod.e2e-spec.js
with
22 additions
and
0 deletions
deploy/bkwdCompat/urlState.js
+
5
−
0
View file @
97efb4ae
...
...
@@ -209,5 +209,10 @@ module.exports = query => {
return
redirectUrl
}
if
(
Array
.
from
(
searchParam
.
keys
()).
length
>
0
)
{
redirectUrl
+=
`/?
${
searchParam
.
toString
()}
`
return
redirectUrl
}
return
null
}
This diff is collapsed.
Click to expand it.
e2e/src/advanced/urlParsing.prod.e2e-spec.js
+
17
−
0
View file @
97efb4ae
...
...
@@ -88,6 +88,23 @@ describe('> url parsing', () => {
it
(
'
> if using niftilayers should show deprecation worning
'
)
it
(
'
> pluginStates should be fetched even if no template or parc are selected
'
,
async
()
=>
{
const
searchParam
=
new
URLSearchParams
()
searchParam
.
set
(
'
pluginStates
'
,
'
http://localhost:3001/manifest.json
'
)
await
iavPage
.
goto
(
`/?
${
searchParam
.
toString
()}
`
,
{
interceptHttp
:
true
,
doNotAutomate
:
true
})
await
iavPage
.
wait
(
10000
)
const
interceptedCalls
=
await
iavPage
.
getInterceptedHttpCalls
()
expect
(
interceptedCalls
).
toContain
(
jasmine
.
objectContaining
(
{
method
:
'
GET
'
,
url
:
'
http://localhost:3001/manifest.json
'
}
))
})
it
(
'
> pluginStates should result in xhr to get pluginManifest
'
,
async
()
=>
{
const
searchParam
=
new
URLSearchParams
()
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment