Skip to content
Snippets Groups Projects
Unverified Commit 770fb21c authored by xgui3783's avatar xgui3783 Committed by GitHub
Browse files

Merge pull request #830 from HumanBrainProject/bugfix_loggedInUserDatasetFetch

Bugfix logged in user dataset fetch
parents 9ff443e8 c2ec7933
No related branches found
No related tags found
No related merge requests found
......@@ -59,7 +59,7 @@ const fetchDatasetFromKg = async ({ user } = {}) => {
const { releasedOnly, option } = await getUserKGRequestParam({ user })
return await new Promise((resolve, reject) => {
request(`${KG_QUERY_DATASETS_URL}${releasedOnly ? '&databaseScope=RELEASED' : ''}`, option, (err, resp, body) => {
request(`${KG_QUERY_DATASETS_URL}${releasedOnly ? '&databaseScope=RELEASED' : '&databaseScope=INFERRED'}`, option, (err, resp, body) => {
if (err) return reject(err)
if (resp.statusCode >= 400) return reject(resp.statusCode)
try {
......@@ -108,8 +108,11 @@ const getPublicDs = async () => {
throw `cached Data not yet resolved, neither is get public ds defined`
}
const getDs = ({ user }) => (user
/**
* force get only public ds
* getting individual ds is too slow
*/
const getDs = ({ user }) => (false && user
? fetchDatasetFromKg({ user }).then(({ results }) => results)
: getPublicDs()
).then(async datasets => {
......
......@@ -21,8 +21,9 @@ const getUserKGRequestParam = async ({ user }) => {
let publicAccessToken
/**
* n.b. ACCESS_TOKEN env var is usually only set during dev
* user.type any other than 'hbp-oidc' (v1 of oidc) will result in timeout/error
*/
const accessToken = (user && user.tokenset && user.tokenset.access_token) || process.env.ACCESS_TOKEN
const accessToken = (user && user.type === 'hbp-oidc' && user.tokenset && user.tokenset.access_token) || process.env.ACCESS_TOKEN
const releasedOnly = !accessToken
if (!accessToken && getPublicAccessToken) {
publicAccessToken = await getPublicAccessToken()
......
# v2.3.3
## Bugfixes
- fix bug where fetching of regional features does not complete for logged in users (#826). (the viewer will only fetch released datasets)
\ No newline at end of file
......@@ -40,6 +40,7 @@ pages:
- Fetching datasets: 'advanced/datasets.md'
- Display non-atlas volumes: 'advanced/otherVolumes.md'
- Release notes:
- v2.3.3: 'releases/v2.3.3.md'
- v2.3.2: 'releases/v2.3.2.md'
- v2.3.1: 'releases/v2.3.1.md'
- v2.3.0: 'releases/v2.3.0.md'
......
{
"name": "interactive-viewer",
"version": "2.3.2",
"version": "2.3.3",
"description": "HBP interactive atlas viewer. Integrating KG query, dataset previews & more. Based on humanbrainproject/nehuba & google/neuroglancer. Built with angular.io",
"scripts": {
"dev-server-export": "webpack-dev-server --config webpack.export.js",
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment