Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
siibra-explorer
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Xiao Gui
siibra-explorer
Commits
1e450220
Commit
1e450220
authored
3 years ago
by
Xiao Gui
Browse files
Options
Downloads
Patches
Plain Diff
bugfix: e2e failing on parseUrl
parent
edc60996
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
e2e/protractor.conf.js
+2
-2
2 additions, 2 deletions
e2e/protractor.conf.js
e2e/src/advanced/urlParsing.prod.e2e-spec.js
+9
-4
9 additions, 4 deletions
e2e/src/advanced/urlParsing.prod.e2e-spec.js
with
11 additions
and
6 deletions
e2e/protractor.conf.js
+
2
−
2
View file @
1e450220
...
...
@@ -42,7 +42,7 @@ const localConfig = {
// polyfill for node10 or lower
if
(
typeof
globalThis
===
'
undefined
'
)
global
.
globalThis
=
{}
jasmine
.
getEnv
().
addReporter
({
specDone
:
async
({
status
,
id
,
fullName
,
...
rest
})
=>
{
specDone
:
async
({
status
,
id
,
message
,
fullName
,
...
rest
})
=>
{
if
(
status
===
'
failed
'
)
{
console
.
log
(
`spec failed, taking screenshot`
)
const
b64
=
await
globalThis
.
IAVBase
.
takeScreenshot
()
...
...
@@ -55,7 +55,7 @@ const localConfig = {
)
await
asyncWrite
(
path
.
join
(
dir
,
`
${
id
}
.txt`
),
JSON
.
stringify
({
id
,
status
,
fullName
},
null
,
2
),
JSON
.
stringify
({
id
,
status
,
message
,
fullName
},
null
,
2
),
'
utf-8
'
)
}
...
...
This diff is collapsed.
Click to expand it.
e2e/src/advanced/urlParsing.prod.e2e-spec.js
+
9
−
4
View file @
1e450220
const
{
AtlasPage
}
=
require
(
"
../util
"
)
const
proxy
=
require
(
'
selenium-webdriver/proxy
'
)
const
{
ARIA_LABELS
}
=
require
(
'
../../../common/constants
'
)
describe
(
'
> url parsing
'
,
()
=>
{
let
iavPage
...
...
@@ -77,12 +75,19 @@ describe('> url parsing', () => {
await
iavPage
.
wait
(
5000
)
await
iavPage
.
waitForAsync
()
const
log
=
await
iavPage
.
getLog
()
const
filteredLog
=
log
.
filter
(({
message
})
=>
!
/Access-Control-Allow-Origin/
.
test
(
message
))
const
filteredLog
=
log
// in headless & non gpu mode, a lot of webgl warnings are thrown
.
filter
(({
level
})
=>
level
.
toString
()
===
'
SEVERE
'
)
.
filter
(({
message
})
=>
!
/Access-Control-Allow-Origin/
.
test
(
message
))
// expecting some errors in the console. In catastrophic event, there will most likely be looped errors (on each render cycle)
// capture logs and write to spec https://stackoverflow.com/a/24980483/6059235
expect
(
filteredLog
.
length
).
toBeLessThan
(
50
)
).
toBeLessThan
(
50
,
JSON
.
stringify
(
filteredLog
)
)
})
it
(
'
> if niftiLayers are defined, parcellation layer should be hidden
'
,
async
()
=>
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment