Merge pull request #734 from HumanBrainProject/exmpt_ariaTxtUnitTexts

Exmpt aria txt unit texts

common/constants.js

@@ -19,6 +19,8 @@
     PIN_DATASET: 'Toggle pinning dataset',
     TEXT_INPUT_SEARCH_REGION: 'Search for any region of interest in the atlas selected',
     CLEAR_SELECTED_REGION: 'Clear selected region',
+    BULK_DOWNLOAD: `Download all pinned data`,
+    NO_BULK_DOWNLOAD: `No datasets pinned`,
 
     // overlay/layout specific
     SELECT_ATLAS: 'Atlas',

src/ui/databrowserModule/bulkDownload/bulkDownloadBtn.component.ts

@@ -2,9 +2,10 @@ import { Component, Input, OnChanges, Pipe, PipeTransform, ChangeDetectionStrate
 import { BACKENDURL } from 'src/util/constants'
 import { IDataEntry } from "src/services/stateStore.service";
 import { getKgSchemaIdFromFullId } from "../util/getKgSchemaIdFromFullId.pipe";
+import { ARIA_LABELS } from 'common/constants'
 
-const ARIA_LABEL_HAS_DOWNLOAD = `Bulk download all favourited datasets`
-const ARIA_LABEL_HAS_NO_DOWNLOAD = `No favourite datasets to download`
+const ARIA_LABEL_HAS_DOWNLOAD = ARIA_LABELS.BULK_DOWNLOAD
+const ARIA_LABEL_HAS_NO_DOWNLOAD = ARIA_LABELS.NO_BULK_DOWNLOAD
 
 @Component({
   selector: 'iav-datamodule-bulkdownload-cmp',

src/ui/databrowserModule/bulkDownload/bulkDownloadBtn.template.html

@@ -13,7 +13,7 @@
     <button mat-icon-button
       [attr.aria-label]="ariaLabel"
       [ngClass]="{'text-muted': kgIds.length === 0}"
-      [matTooltip]="kgIds.length === 0 ? 'No favourite datasets to download' : 'Bulk download all favourited datasets'"
+      [matTooltip]="ariaLabel"
       (click)="kgIds.length === 0 ? null : bulkDlForm.submit()">
       <i class="fas fa-download"></i>
     </button>

src/ui/regionalFeatures/regionGetAllFeatures.directive.ts

 import { Directive, EventEmitter, OnDestroy, OnInit, Output } from "@angular/core";
 import { Subscription } from "rxjs";
+import { RegionalFeaturesService } from "./regionalFeature.service";
 import { RegionFeatureBase } from "./regionFeature.base";
 
 @Directive({
@@ -13,6 +14,16 @@ export class RegionGetAllFeaturesDirective extends RegionFeatureBase implements
 
   private subscriptions: Subscription[] = []
 
+  /**
+   * since the base class has DI
+   * sub class needs to call super() with the correct DI
+   */
+  constructor(
+    rfService: RegionalFeaturesService
+  ){
+    super(rfService)
+  }
+
   ngOnInit(){
     this.subscriptions.push(
       this.isLoading$.subscribe(val => {