Add labextension ipycanvas
Merge request reports
Activity
Hi Eric, sorry I only saw your MR now.
The extension is fine to add but it would be great if you could:
- Include the version number to avoid potential version conflicts with the installed jupyter version
- Do the extension install as part of the previous command with the "--no-build" option, this speeds up the build process of the docker image
Hey @deuerlei,
thanks for the review. I also dropped
@jupyter-widgets/jupyterlab-manager
as this should be covered by the pip-based install in newer JupyterLab versions (I'm no expert in this ).However, the "old-skool" install of
ipycanvas@0.12.0
here seems needed as spack can't modify the lab extensions directory after this image has been built, i.e. only the Python parts are installed by spack.Edited by Eric MüllerHi @emuller
Thanks for the update. We'll include the ipycanvas install in the next image release.
Thanks also for the additional details. The recommend way of installing extension is now via pip packages only, which can also include the install of the frontend components via npm. If ipycanvas needs to be installed this way it fine as well though.
mentioned in commit 2da51e44