Skip to content
Snippets Groups Projects
Commit 04258f9c authored by John W. Parent's avatar John W. Parent Committed by Harmen Stoppels
Browse files

Prefer llnl.util.symlink.readlink to os.readlink (#44126)

Symlinks on Windows can use longpath prefixes (\\?\); these are fine
in the context of win32 API interactions but break numerous facets of
Spack behavior that rely on string parsing/matching (archiving,
binary distributions, tarball extraction, view regen, etc).

Spack's internal readlink method (llnl.util.symlink.readlink)
gracefully handles this by removing the prefix and otherwise behaving
exactly as os.readlink does, so we should prefer that in all cases.
parent 1b14170b
No related branches found
No related tags found
No related merge requests found
Showing
with 42 additions and 28 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment