Fix: pynn-brainscales build depends on py-pyyaml
(Before we somehow used the runtime dependency on py-pyyaml.)
Merge request reports
Activity
Hi @emuller,
Thanks for this.
Probably this behavior is due to the updated Spack instance and the new Spack env. I think it is good that we observed this because now the pynn-brainscales package is more complete (with the inclusion of the py-pyyaml dependency).
Merging now.
mentioned in commit d9a1f32b
Yes, it shouldn't have worked before and it's better now ;)…
BTW. the
setup_build_environment(…)function in this package is also quite hacky ⇒ I think we could just move all dependencies frommeta-brainscalesintopynn-brainscales, dropmeta-brainscalesand be just fine.[I originally did it that way (i.e. splitting out the "upstream" dependencies of BrainScaleS software into a meta package) to be able to incrementally approach the "all required dependencies available" state… but now I'm not so sure if this was a good idea back then ;)]
Great!
What you propose will simplify things and reduce the number of packages we have to care about. So i am all in :)
Also regarding the previous MR, since from what you said you basically contributed the upstream llvm package, could not we drop also the llvm package from the ebrains-spack-builds packages and let it be pulled from upstream?
→ new MR !71 (merged)
