fix(llvm): add_files_to_view() got unexpected argument

Hi @emuller, In the last build tests there is this error when creating the env view, from the add_files_to_view() defined in the llvm package:

==> Error: add_files_to_view() got an unexpected keyword argument 'skip_if_exists'

The skip_if_exists keyword has been there for a long time, before Spack v0.18.0, and the method def was fixed in the ebrains repo, until I copied your llvm spack package last week.

getting rid of the error is easy, I just wanted to ask, since this can't have worked (for you) since spack v0.18.0, maybe it's not really needed?

packages/llvm/package.py

@@ -392,9 +392,6 @@ class Llvm(CMakePackage, CudaPackage):
     variant('visionary', default=False,
             description="Include patches necessary for visionary python "
             "bindings generator")
-    variant('force_full_view', default=False,
-            description='Force linking of all files into view, including '
-                        'known conflicts (e.g. libgomp).')
 
     conflicts("@:8", when="+visionary")
     conflicts("@13:", when="+visionary")
@@ -1018,26 +1015,6 @@ class Llvm(CMakePackage, CudaPackage):
         with working_dir(self.build_directory):
             install_tree("bin", join_path(self.prefix, "libexec", "llvm"))
 
-    # begin VISIONS (added)
-    def add_files_to_view(self, view, merge_map):
-        python = self.spec["python"]
-        # we remove libgomp-related files from views as they conflict with
-        # gcc- or python-ones
-        ignore_file_paths = [
-            join_path(self.prefix, "lib", "libgomp.so"),
-            join_path(self.prefix, "lib",
-                      f"python{'.'.join(str(python.version).split('.')[:2])}",
-                      "site-packages", "README.txt"),
-        ]
-
-        if self.spec.satisfies('~force_full_view'):
-            for path in ignore_file_paths:
-                if path in merge_map:
-                    del merge_map[path]
-
-        super(Llvm, self).add_files_to_view(view, merge_map)
-    # end VISIONS
-
     def llvm_config(self, *args, **kwargs):
         lc = Executable(self.prefix.bin.join("llvm-config"))
         if not kwargs.get("output"):