Skip to content
Snippets Groups Projects

Update Neo to 0.13.0

All threads resolved!

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Eleni MathioulakiEleni Mathioulaki 1 year ago (Apr 11, 2024 12:58pm UTC)

Merge details

  • Changes merged into master with 0e51d7a3 (commits were squashed).
  • Deleted the source branch.

Pipeline #28798 waiting for manual action

Pipeline waiting for manual action for 0e51d7a3 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @adavison, thanks for the MR :) From what I can see there are 2 errors:

    When testing pyNN, one test fails:

    =================================== FAILURES ===================================
    ___________________________________ test_get ___________________________________
    
        def test_get():
            p = MockPopulation()
            r = MockRecorder(p)
    >       data = r.get('spikes')
    
    test/unittests/test_recording.py:167: 
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
    /builds/cnrs-neuroinformatics/ebrains-spack-builds/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-10.3.0/py-pynn-0.11.0-3d6bl3xzqbzzgqgucvpqeq3odfxhj2mx/lib/python3.8/site-packages/pyNN/recording/__init__.py:399: in get
        data.segments.append(self._get_current_segment(
    /builds/cnrs-neuroinformatics/ebrains-spack-builds/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-10.3.0/py-neo-0.13.0-63tbsdzlz44ouptgh2xoluid4usbl3le/lib/python3.8/site-packages/neo/core/objectlist.py:86: in append
        self._handle_append(obj)
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
    
    self = [], obj = <Mock id='139880847983760'>
    
        def _handle_append(self, obj):
            if not (
                isinstance(obj, self.allowed_contents)
                or (  # also allow proxy objects of the correct type
                    hasattr(obj, "proxy_for") and obj.proxy_for in self.allowed_contents
                )
            ):
    >           raise TypeError(f"Object is a {type(obj)}. It should be one of {self.allowed_contents}.")
    E           TypeError: Object is a <class 'unittest.mock.Mock'>. It should be one of (<class 'neo.core.segment.Segment'>,).
    
    /builds/cnrs-neuroinformatics/ebrains-spack-builds/spack/opt/spack/linux-ubuntu20.04-x86_64/gcc-10.3.0/py-neo-0.13.0-63tbsdzlz44ouptgh2xoluid4usbl3le/lib/python3.8/site-packages/neo/core/objectlist.py:34: TypeError

    Also, when testing elephant, the test/test_neo_tools.py::GetAllEventsTestCase::test__get_all_events__segment test is killed - I could quickly reproduce it locally, it's killed during the extend() here. When I changed it to self.contents.extend(list(objects)) it passed, so I'm guessing sth type-related? :)

  • Moritz Kern mentioned in merge request !531 (merged)

    mentioned in merge request !531 (merged)

  • Eleni Mathioulaki added 93 commits

    added 93 commits

    Compare with previous version

  • Eleni Mathioulaki resolved all threads

    resolved all threads

Please register or sign in to reply