Skip to content
Snippets Groups Projects

Add r UQ workflow metapackage

Merged Eleni Mathioulaki requested to merge add-r-workflow into master

Merge request reports

Pipeline #21204 passed

Pipeline passed for f9302866 on add-r-workflow

Approval is optional

Merged by Eleni MathioulakiEleni Mathioulaki 2 years ago (Feb 22, 2023 12:52am UTC)

Merge details

  • Changes merged into master with acb0f9f6 (commits were squashed).
  • Deleted the source branch.

Pipeline #21205 canceled

Pipeline canceled for acb0f9f6 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in commit acb0f9f6

  • @akramer I created this meta-package as a quick solution to track the dependencies of your demo. Could you have a look and open a MR for any changes you think are needed? The name is probably not ideal, I just used the name of your notebook. Also, I guess your packages, r-rgsl and r-sbtabfgen, (and also maybe uq? once you add it) should be added as dependencies.

  • Hello Eleni @elmath I have created a branch that has very similar dependencies: https://gitlab.ebrains.eu/akramer/ebrains-spack-builds/-/commits/add-r-uqsa

    r-vinecopula is not among the pre-exisiting spack packages, so I also made a package.py for r-vinecopula itself in the same branch (without adding it to spack.yaml as it is implicit in uqsa). Last night the pipeline failed when building the spack environemnt (build-spack-env-on-runner). Once the pipeline works I'll submit a merge request. Do you think this meta-package is still required? It looks to me like they have the same list of dependencies.

  • Hi @akramer, in general for the pipeline to work as expected you need your branch to be up-to-date with master - I opened a Merge Request that updates your branch. If you have trouble resolving the conflicts, you can add me as a member to your forked project and I will do it.

    In this case however, the issue is that in the uqsa dependencies r-MASS should be r-mass (all package names in spack are lowercase, see here). In general when you are working on something it's good to open a Merge Request even before it's ready, I try to have a look and offer some help when needed :)

  • Hi @elmath

    you can add me as a member to your forked project and I will do it

    I think I already did that.

    I tried just now, this is also new to me but I did what suggests for "resolve locally". I don't know if that has worked.

    Yesterday I was hoping to add the original repository as an additional remote. But, I guess that I cannot pull from it using ssh, as I am not a member and I cannot pull from it via https because I wouldn't know what to use as username and password. I'm guessing that there are no https passwords because of the authentication methods. So, how shoudl I keep the fork up-to-date in the future?

  • OK, I think that the thing that gitlab suggested to resolve conflicts was too cryptic for me. I followed the suggestion to

    git fetch "git@gitlab.ebrains.eu:technical-coordination/project-internal/devops/platform/ebrains-spack-builds.git" 'master'
    git checkout -b 'ebrains-spack-builds-master' FETCH_HEAD

    and then I did this:

    git checkout master
    git merge ebrains-spack-builds-master
    git checkout add-r-uqsa
    git rebase master add-r-uqsa
    git push -f

    still, the pipeline fails at the same stage.

  • I noticed that I can in fact configure an upstream remote and use ssh, neato.

  • Ah, yes, gitlab's instructions are a mess, don't worry about them. What you originally tried to do is the correct way, of course

  • Did you try changing r-MASS to r-mass like I suggested? I think this will work. If you check the pipeline logs, you can see it's complaining that

    ==> Error: Package 'r-MASS' not found.
  • Thank you for the information @elmath (I wrote it correctly in all other files and fixed that one). Do I download the logs by pressing the "download artifacts" button? When I use that, I get a new tab where I see an almost empty page with a red box (one line's worth of red frame). If I reload the page firefox is telling me that the xml is broken.

  • Hmm you are right, the button does not seem to work, I'll ask the gitlab admins.

    In general, you click on the pipeline id, then on "build-spack-env-on-runner" (that is the job that tests the build). There you can quickly see the Spack logs. Then on the right, if you go to Job artifacts -> Browse (the Download button should also work but it doesn't) you can see the logs specifically for each package, by navigating to the package directory and downloading spack-build-out.txt

    Edited by Eleni Mathioulaki
Please register or sign in to reply