Upgrade TVB packages. Add unit-tests
By @ldomide:
Upgrade tvb-data
, tvb-library
, tvb-framework
, tvb-storage
packages.
Add unit-tests with pytest where possible.
Add tvb-gdist
module.
Adjust package names py-tvb-*
Merge request reports
Activity
assigned to @ldomide
@ldomide finally the CI worked as expected, thanks for the patience
. In the Merge Request pipeline logs you can see an error:==> Error: Package 'py-pylems' not found.
The pylems dependency that you added does not exist in the spack upstream, so you need to provide a package.py for it as well. You can see the Spack upstream package list here.
@elmath thank you for pointing towards the py-pylems issue.
It is an optional dependency, I think we can leave without, for now.
I did another commit, but the pipeline does not start automatically...
Edited by Lia Domide@ldomide Thanks! I don't understand what the problem is, it works perfectly when I test it. I'll investigate a bit and get back to you.
@elmath could it be that my user doing the commit it makes a difference (as not having enough rights) ?
@ldomide I don't think this could be the case, other gitlab users have triggered those pipelines successfully even without being members of the project.
Anyway, I tried to reproduce this and couldn't in any way, so I'd like to rule out that it was just a glitch of gitlab being too busy/problem of the underlying infrastructure. Could you please make another commit to check this?
Anyway in the last run of the pipeline, tvb-data builds fine, but there is this error for tvb-gdist:
==> Installing py-tvb-gdist-2.1.0-d7kzif5vxcsfrrcxcyp4iwreb3fvaevr ==> No binary for py-tvb-gdist-2.1.0-d7kzif5vxcsfrrcxcyp4iwreb3fvaevr found: installing from source ==> Fetching https://files.pythonhosted.org/packages/source/t/tvb-gdist/tvb-gdist-2.1.0.tar.gz ==> No patches needed for py-tvb-gdist ==> py-tvb-gdist: Executing phase: 'install' ==> Error: TypeError: 'NoneType' object is not callable /builds/technical-coordination/project-internal/devops/platform/ebrains-spack-builds/packages/py-tvb-gdist/package.py:37, in install_test: 34 def install_test(self): 35 36 pytest = which('pytest') >> 37 pytest() See build log for details: /builds/technical-coordination/project-internal/devops/platform/ebrains-spack-builds/.spack-tmp/root/spack-stage/spack-stage-py-tvb-gdist-2.1.0-d7kzif5vxcsfrrcxcyp4iwreb3fvaevr/spack-build-out.txt
probably because pytest needs to be added as a test dependency.
(There are many non-tvb related errors in the logs since tests are failing for many different packages at the moment, to find the relevant ones you can use search)
added 1 commit
- c7064a7f - No unite-tests packaged inside tvb-gdist on Pypi
added 1 commit
- 8edc4b89 - No unite-tests packaged inside tvb-gdist on Pypi
Hi @ldomide, I'm still trying to understand why pipelines are not triggered automatically (the ones that run today were triggered manually by me). Could you tell me if in the pipelines tab you can click the "Run pipeline" button?
Hi @elmath. Thank you for manually triggering the pipeline today!
I can see and click the button "Run pipeline", but there is an error when i click it. The link "learn more" only takes me here https://gitlab.ebrains.eu/help/ci/pipelines/merge_request_pipelines.md
unassigned @ldomide
assigned to @ldomide
added 1 commit
- c4654c1f - Attempt different run of pytest on tvb-library