chore(build-brainscales): define base dependencies

We do always depend on git to be available for `waf setup`.

packages/build-brainscales/package.py

@@ -14,6 +14,10 @@ import spack.build_environment
 class BuildBrainscales(WafPackage):
     """Common stuff for BrainScaleS packages..."""
 
+    # waf setup performs git clone and might query gerrit
+    depends_on('git', type=('build', 'link'))
+    depends_on('py-git-review', type=('build', 'link'))
+
     def do_fetch(self, mirror_only=False):
         """Setup the project."""
 

packages/hxtorch/package.py

@@ -47,7 +47,6 @@ class Hxtorch(build_brainscales.BuildBrainscales):
     depends_on('cppcheck', type=('build', 'link', 'run'))
     depends_on('genpybind@ebrains', type=('build', 'link', 'run'))
     depends_on('gflags', type=('build', 'link', 'run'))
-    depends_on('git', type=('build', 'link'))
     depends_on('googletest@1.11.0:+gmock', type=('build', 'link', 'run')) # variadic templates needed
     depends_on('inja', type=('build', 'link', 'run', 'test')) # template engine for PPU source jit generation
     depends_on('intel-tbb', type=('build', 'link', 'run'))  # ppu gdbserver
@@ -57,7 +56,6 @@ class Hxtorch(build_brainscales.BuildBrainscales):
     depends_on('pkgconfig', type=('build', 'link', 'run'))
     depends_on('psmisc', type=('run', 'test'))
     depends_on('python@3.7.0:', type=('build', 'link', 'run')) # BrainScaleS-2 only supports Python >= 3.7
-    depends_on('py-git-review', type=('build', 'link'))
     depends_on('py-h5py', type=('build', 'link', 'run')) # PyNN tests need it
     depends_on('py-jax@0.3.25:', type=('build', 'link', 'run'))
     depends_on('py-matplotlib', type=('build', 'link', 'run'))

packages/pynn-brainscales/package.py

@@ -47,7 +47,6 @@ class PynnBrainscales(build_brainscales.BuildBrainscales):
     depends_on('cppcheck', type=('build', 'link', 'run'))
     depends_on('genpybind@ebrains', type=('build', 'link', 'run'))
     depends_on('gflags', type=('build', 'link', 'run'))
-    depends_on('git', type=('build', 'link'))
     depends_on('googletest@1.11.0:+gmock', type=('build', 'link', 'run')) # variadic templates needed
     depends_on('inja', type=('build', 'link', 'run', 'test')) # template engine for PPU source jit generation
     depends_on('intel-tbb', type=('build', 'link', 'run'))  # ppu gdbserver
@@ -58,7 +57,6 @@ class PynnBrainscales(build_brainscales.BuildBrainscales):
     depends_on('psmisc', type=('run', 'test'))
     depends_on('python@3.7.0:', type=('build', 'link', 'run')) # BrainScaleS-2 only supports Python >= 3.7
     depends_on('py-deap@1.3.1:', type=('build', 'link', 'run'))
-    depends_on('py-git-review', type=('build', 'link'))
     depends_on('py-h5py', type=('build', 'link', 'run')) # PyNN tests need it
     depends_on('py-matplotlib', type=('build', 'link', 'run'))
     depends_on('py-nose', type=('build', 'link', 'run'))