fix: Allow unset build-cache-on-failure-name

Change-Id: I1c032ef37cbfbf82a04aceb17d1275f344122e44

lib/yashchiki/preserve_built_spack_packages.sh

@@ -23,6 +23,11 @@ sourcedir="$(dirname "$(readlink -m "${BASH_SOURCE[0]}")")"
 source "${sourcedir}/commons.sh"
 source "${sourcedir}/setup_env_spack.sh"
 
+if [ -z "${YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME:-}" ]; then
+    echo "No name for build cache on failure given, skipping saving preserved packages."
+    exit 0
+fi
+
 # find empty directory to dump into
 build_num=1
 while /bin/true; do

share/yashchiki/styles/asic/create_recipe.sh

@@ -250,7 +250,7 @@ From: ${DOCKER_BASE_IMAGE}
     export YASHCHIKI_SPACK_CONFIG="/tmp/spack_config"
     export YASHCHIKI_CACHES_ROOT="${YASHCHIKI_CACHES_ROOT}"
     export YASHCHIKI_BUILD_CACHE_NAME="${YASHCHIKI_BUILD_CACHE_NAME}"
-    export YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME="${YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME}"
+    export YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME="${YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME:-}"
     export YASHCHIKI_SPACK_VERBOSE="${YASHCHIKI_SPACK_VERBOSE}"
     export YASHCHIKI_DEBUG=${YASHCHIKI_DEBUG}
     export CONTAINER_STYLE="${CONTAINER_STYLE}"

share/yashchiki/styles/visionary/create_recipe.sh

@@ -80,7 +80,7 @@ From: ${DOCKER_BASE_IMAGE}
     export YASHCHIKI_SPACK_CONFIG="/tmp/spack_config"
     export YASHCHIKI_CACHES_ROOT="${YASHCHIKI_CACHES_ROOT}"
     export YASHCHIKI_BUILD_CACHE_NAME="${YASHCHIKI_BUILD_CACHE_NAME}"
-    export YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME="${YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME}"
+    export YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME="${YASHCHIKI_BUILD_CACHE_ON_FAILURE_NAME:-}"
     export YASHCHIKI_SPACK_VERBOSE="${YASHCHIKI_SPACK_VERBOSE}"
     export YASHCHIKI_DEBUG=${YASHCHIKI_DEBUG}
     export CONTAINER_STYLE="${CONTAINER_STYLE}"