chore: Move visionary-dev-tools spec out of commons.sh

Change-Id: I5f547f0c7b8ae5f4cbd4ed0b6890528ac023ccd0

lib/yashchiki/commons.sh

@@ -170,9 +170,6 @@ fi
 # PACKAGES #
 ############
 
-# the version of dev tools we want in our view
-SPEC_VIEW_VISIONARY_DEV_TOOLS="visionary-dev-tools ^${DEPENDENCY_PYTHON} %${YASHCHIKI_SPACK_GCC}"
-
 # used in VIEWS section below but needs to be defined before sourcing
 # associative array: spec to add -> view names seperated by spaces
 declare -A spack_add_to_view

share/yashchiki/styles/asic/spack_collection.sh

 # All spack packages that should be fetched/installed in the container
 spack_packages=(
-#    "${SPEC_VIEW_VISIONARY_DEV_TOOLS}" # FIXME
+#    "visionary-dev-tools ^${DEPENDENCY_PYTHON} %${YASHCHIKI_SPACK_GCC}" # FIXME
     "visionary-asic ^${DEPENDENCY_PYTHON} %${YASHCHIKI_SPACK_GCC}"
 )
 

share/yashchiki/styles/visionary/spack_collection.sh

 # All spack packages that should be fetched/installed in the container
 spack_packages=(
-    "${SPEC_VIEW_VISIONARY_DEV_TOOLS}"
+    "visionary-dev-tools ^${DEPENDENCY_PYTHON} %${YASHCHIKI_SPACK_GCC}"
     # START python 3 packages
     "visionary-wafer~dev ^${DEPENDENCY_PYTHON} %${YASHCHIKI_SPACK_GCC}"
     "visionary-wafer ^${DEPENDENCY_PYTHON} %${YASHCHIKI_SPACK_GCC}"

share/yashchiki/styles/visionary/spack_custom_view.sh

@@ -22,5 +22,5 @@ ${MY_SPACK_BIN} ${SPACK_ARGS_VIEW[@]+"${SPACK_ARGS_VIEW[@]}"} view -d yes symlin
 # dev tools #
 #############
 
-${MY_SPACK_BIN} ${SPACK_ARGS_VIEW[@]+"${SPACK_ARGS_VIEW[@]}"} view -d yes symlink -i ${MY_SPACK_VIEW_PREFIX}/visionary-dev-tools $(get_latest_hash "${SPEC_VIEW_VISIONARY_DEV_TOOLS}")
+${MY_SPACK_BIN} ${SPACK_ARGS_VIEW[@]+"${SPACK_ARGS_VIEW[@]}"} view -d yes symlink -i ${MY_SPACK_VIEW_PREFIX}/visionary-dev-tools $(get_latest_hash "visionary-dev-tools ^${DEPENDENCY_PYTHON} %${YASHCHIKI_SPACK_GCC}")
 EOF