Skip to content
Snippets Groups Projects
Commit 723b4fe5 authored by Viktor Vorobev's avatar Viktor Vorobev Committed by Ugo Albanese
Browse files

Merged in NRRPLT-8551 (pull request #90)

[NRRPLT-8551] Exit from devinstall on failed installation.

When some module is not installed, make devinstall just continues without throwing an error. This creates an illusion that the installation is going to be successful but it can fail.

* [NRRPLT-8551] Delete EPFL placeholder

Approved-by: Ugo Albanese
parent 177e2561
No related branches found
No related tags found
No related merge requests found
...@@ -75,12 +75,8 @@ print-%: ...@@ -75,12 +75,8 @@ print-%:
devinstall: virtualenv devinstall: virtualenv
for f in $(INSTALL_MODULES); do \ for f in $(INSTALL_MODULES); do \
if [ -f $$f/setup_requirements.txt ]; then \ [ -f $$f/setup_requirements.txt ] && $(PIP) install $(PIPPROXY) -r $$f/setup_requirements.txt; \
$(PIP) install $(PIPPROXY) -r $$f/setup_requirements.txt; \ (cd $$f && $(PIP) install $(PIPPROXY) --pre -e .$(OPTIONAL_FEATURES)) || exit 1; \
fi; \
sed -i 's/.*# *EPFL_SPECIFIC/#&/' $$f/requirements.txt; \
(cd $$f && $(PIP) install $(PIPPROXY) --pre -e .$(OPTIONAL_FEATURES)); \
sed -i '/# *EPFL_SPECIFIC/s/^#*//' $$f/requirements.txt; \
done done
#delete everything we don't need #delete everything we don't need
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment