Skip to content
Snippets Groups Projects

Dev/mip 62/mip engine integration with the mip portalbackend

Created by: KFilippopolitis

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kostas FILIPPOPOLITIS
  • Kostas FILIPPOPOLITIS
  • Kostas FILIPPOPOLITIS
  • Kostas FILIPPOPOLITIS
  • Kostas FILIPPOPOLITIS
  • Kostas FILIPPOPOLITIS
  • Kostas FILIPPOPOLITIS
  • Kostas FILIPPOPOLITIS
  • Kostas FILIPPOPOLITIS
  • Created by: ThanKarab

    Review: Changes requested

    Nice work!

    Quick summary:

    1. Remove all converters and create constructors.
    2. Move Galaxy calls to a separate "GalaxyService".
    3. Rename all internal classes with the proper prefix (MIPEngine or Exareme)

    minor: use localhost instead of internal ip.

  • Created by: ThanKarab

    Review: Approved

  • Merged by: ThanKarab at 2021-07-19 08:38:33 UTC

  • Please register or sign in to reply