Skip to content
Snippets Groups Projects
Commit 4e0402e8 authored by Mirco Nasuti's avatar Mirco Nasuti
Browse files

refactor experiment running

parent ddad684f
No related branches found
No related tags found
No related merge requests found
...@@ -73,28 +73,24 @@ public class ExperimentApi { ...@@ -73,28 +73,24 @@ public class ExperimentApi {
@ApiOperation(value = "Send a request to the workflow to run an experiment", response = Experiment.class) @ApiOperation(value = "Send a request to the workflow to run an experiment", response = Experiment.class)
@RequestMapping(method = RequestMethod.POST) @RequestMapping(method = RequestMethod.POST)
public ResponseEntity<String> runExperiment(@RequestBody ExperimentQuery incomingQueryObj) { public ResponseEntity<String> runExperiment(@RequestBody ExperimentQuery expQuery) {
LOGGER.info("Run an experiment"); LOGGER.info("Run an experiment");
String incomingQueryString = gson.toJson(incomingQueryObj);
JsonObject incomingQuery = gsonOnlyExposed.fromJson(incomingQueryString, JsonObject.class);
Experiment experiment = new Experiment(); Experiment experiment = new Experiment();
experiment.setUuid(UUID.randomUUID()); experiment.setUuid(UUID.randomUUID());
User user = securityConfiguration.getUser(); User user = securityConfiguration.getUser();
experiment.setAlgorithms(incomingQuery.get("algorithms").toString()); experiment.setAlgorithms(gson.toJson(expQuery.getAlgorithms()));
experiment.setValidations(incomingQuery.get("validations").toString()); experiment.setValidations(gson.toJson(expQuery.getValidations()));
experiment.setName(incomingQuery.get("name").getAsString()); experiment.setName(expQuery.getName());
experiment.setCreatedBy(user); experiment.setCreatedBy(user);
experiment.setModel(modelRepository.findOne(incomingQuery.get("model").getAsString())); experiment.setModel(modelRepository.findOne(expQuery.getModel()));
experimentRepository.save(experiment); experimentRepository.save(experiment);
LOGGER.info("Experiment saved"); LOGGER.info("Experiment saved");
try { try {
if(isExaremeAlgo(experiment)) if(isExaremeAlgo(expQuery))
{ {
sendExaremeExperiment(experiment); sendExaremeExperiment(experiment);
} }
...@@ -349,10 +345,10 @@ public class ExperimentApi { ...@@ -349,10 +345,10 @@ public class ExperimentApi {
experiment.setResult(e.getMessage()); experiment.setResult(e.getMessage());
} }
private static boolean isExaremeAlgo(Experiment experiment) { private static boolean isExaremeAlgo(ExperimentQuery expQuery) {
JsonArray algorithms = new JsonParser().parse(experiment.getAlgorithms()).getAsJsonArray(); if (expQuery.getAlgorithms().size() < 1)
String algoCode = algorithms.get(0).getAsJsonObject().get("code").getAsString(); return false;
return "glm_exareme".equals(algoCode); return "glm_exareme".equals(expQuery.getAlgorithms().get(0).getCode());
} }
} }
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment