Skip to content
Snippets Groups Projects
Commit e9f9a8f7 authored by Steve Reis's avatar Steve Reis
Browse files

Merge branch 'sprint-1/issue-71' into 'beta'

[SPRINT-1][Issue-71] Fix logistic regression CV

See merge request sibmip/gateway!103
parents 7c782e59 a51616d3
No related branches found
No related tags found
No related merge requests found
......@@ -47,7 +47,7 @@ export default class LogisticRegressionCVHandler extends BaseHandler {
private canHandle(experiment: Experiment, data: unknown): boolean {
return (
experiment.algorithm.name.toLowerCase() ===
LogisticRegressionCVHandler.ALGO_NAME &&
LogisticRegressionCVHandler.ALGO_NAME &&
!!data &&
!!data[0] &&
!!data[0]['summary']
......@@ -61,7 +61,10 @@ export default class LogisticRegressionCVHandler extends BaseHandler {
name: lookupDict[key],
type: 'string',
})),
data: data.summary['row_names'].map((key: any, i: number) => [key, ...keys.map((k) => `${data['summary'][k][i]}`)])
data: data.summary['row_names'].map((key: any, i: number) => [
key,
...keys.map((k) => `${data['summary'][k][i]}`),
]),
};
}
......@@ -70,7 +73,10 @@ export default class LogisticRegressionCVHandler extends BaseHandler {
return {
name: 'Confusion matrix',
matrix: [[matrix['tp']], [matrix['fp']], [matrix['fn']], [matrix['tn']]],
matrix: [
[matrix['tp'], matrix['fp']],
[matrix['fn'], matrix['tn']],
],
xAxis: {
categories: ['Positive', 'Negative'],
label: 'Actual Values',
......@@ -128,8 +134,10 @@ export default class LogisticRegressionCVHandler extends BaseHandler {
this.getROC(improvedData),
];
results.filter((r) => !!r).forEach((r) => {
experiment.results.push(r);
});
results
.filter((r) => !!r)
.forEach((r) => {
experiment.results.push(r);
});
}
}
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment