WIP : uniform experiment and transient

api/src/engine/connectors/datashield/main.connector.ts

@@ -5,6 +5,11 @@ import { ExperimentCreateInput } from 'src/engine/models/experiment/experiment-c
 import { Experiment } from 'src/engine/models/experiment/experiment.model';
 
 export default class DataShieldService implements IEngineService {
+  createExperiment(
+    data: ExperimentCreateInput,
+  ): Experiment | Promise<Experiment> {
+    throw new Error('Method not implemented.');
+  }
   createTransient(
     data: ExperimentCreateInput,
   ): Experiment | Promise<Experiment> {

api/src/engine/connectors/exareme/main.connector.ts

@@ -24,6 +24,11 @@ export default class ExaremeService implements IEngineService {
     private readonly options: IEngineOptions,
     private readonly httpService: HttpService,
   ) {}
+  createExperiment(
+    data: ExperimentCreateInput,
+  ): Experiment | Promise<Experiment> {
+    throw new Error('Method not implemented.');
+  }
 
   async createTransient(data: ExperimentCreateInput): Promise<Experiment> {
     const form = experimentInputToData(data);

api/src/engine/engine.interfaces.ts

@@ -10,8 +10,18 @@ export interface IEngineOptions {
 }
 
 export interface IEngineService {
+  //GraphQL
   getDomains(ids: string[]): Domain[] | Promise<Domain[]>;
 
+  createTransient(
+    data: ExperimentCreateInput,
+  ): Promise<Experiment> | Experiment;
+
+  createExperiment(
+    data: ExperimentCreateInput,
+  ): Promise<Experiment> | Experiment;
+
+  // Standard REST API call
   getAlgorithms(request: Request): Observable<string>;
 
   getExperiments(request: Request): Observable<string>;
@@ -24,10 +34,6 @@ export interface IEngineService {
 
   startExperimentTransient(request: Request): Observable<string>;
 
-  createTransient(
-    data: ExperimentCreateInput,
-  ): Promise<Experiment> | Experiment;
-
   startExperiment(request: Request): Observable<string>;
 
   getActiveUser(request: Request): Observable<string>;

api/src/engine/engine.resolver.ts

@@ -21,9 +21,13 @@ export class EngineResolver {
   }
 
   @Mutation(() => Experiment)
-  async createTransient(
+  async createExperiment(
     @Args('data') experimentCreateInput: ExperimentCreateInput,
+    @Args('transient', { nullable: true, defaultValue: false })
+    isTransient: boolean,
   ) {
-    return this.engineService.createTransient(experimentCreateInput);
+    return isTransient
+      ? this.engineService.createTransient(experimentCreateInput)
+      : this.engineService.createExperiment(experimentCreateInput);
   }
 }

api/src/schema.gql

@@ -74,7 +74,7 @@ type Query {
 }
 
 type Mutation {
-  createTransient(data: ExperimentCreateInput!): Experiment!
+  createExperiment(transient: Boolean = false, data: ExperimentCreateInput!): Experiment!
 }
 
 input ExperimentCreateInput {