Bug/issue#97 (#102)
This addresses all of the compiler warnings and errors for xlc when compiled at -O0. There are still compiler bugs when compiling with higher optimization levels, however they are more challenging. * Ignore the incorrect `-Wno-missing-braces` warnings (similarly to Clang). * Remove `-qhalt=e flag` inserted by CMake. * Remove redundant comparison of char to EOF in lexer. * The XLC compiler was crashing inexplicably on one call of the following method: ```void run(..., const std::vector<float>& excl={}) {...}``` This was fixed by not having a default value for the last argument. * Add some curly braces to silence warning for dangling else. fixes #97
Showing
- cmake/CompilerOptions.cmake 11 additions, 0 deletionscmake/CompilerOptions.cmake
- modcc/lexer.cpp 1 addition, 2 deletionsmodcc/lexer.cpp
- src/threading/pss_common.h 4 additions, 2 deletionssrc/threading/pss_common.h
- tests/unit/test_uninitialized.cpp 1 addition, 0 deletionstests/unit/test_uninitialized.cpp
- tests/validation/convergence_test.hpp 1 addition, 1 deletiontests/validation/convergence_test.hpp
- tests/validation/validate_soma.hpp 1 addition, 1 deletiontests/validation/validate_soma.hpp
Please register or sign in to comment