Extend and implement extended VALENCE semantics (#781)
Extended USEION VALENCE support. * Augment modcc parser to accept identifier or signed integer after VALENCE. * Treat identifer after VALENCE as global scalar, tied to ionic charge. * Add ionic charge field to mechanism ion parameter pointers, replacing scalar in shared state with a length-1 array. * Verify presence of ion name and check ion charge against numeric valence in mechanism info when discretizing in `fvm_build_mechanism_data`. * Pass ion info, coalesce_synapse global state to `fvm_build_mechanism_data` just via cable cell global properties. * Add more unit-test only mechanisms (test_ca_read_valence, test_cl_valence). * Add unit tests for valence verification and reading into mechanism state (multicore only). * Update existing unit tests for new interfaces. Implements #780.
Showing
- arbor/backends/gpu/mechanism.cpp 1 addition, 0 deletionsarbor/backends/gpu/mechanism.cpp
- arbor/backends/gpu/mechanism.hpp 0 additions, 2 deletionsarbor/backends/gpu/mechanism.hpp
- arbor/backends/gpu/mechanism_ppack_base.hpp 1 addition, 0 deletionsarbor/backends/gpu/mechanism_ppack_base.hpp
- arbor/backends/gpu/shared_state.cpp 4 additions, 4 deletionsarbor/backends/gpu/shared_state.cpp
- arbor/backends/gpu/shared_state.cu 4 additions, 4 deletionsarbor/backends/gpu/shared_state.cu
- arbor/backends/gpu/shared_state.hpp 1 addition, 1 deletionarbor/backends/gpu/shared_state.hpp
- arbor/backends/multicore/mechanism.cpp 1 addition, 0 deletionsarbor/backends/multicore/mechanism.cpp
- arbor/backends/multicore/mechanism.hpp 1 addition, 0 deletionsarbor/backends/multicore/mechanism.hpp
- arbor/backends/multicore/shared_state.cpp 2 additions, 2 deletionsarbor/backends/multicore/shared_state.cpp
- arbor/backends/multicore/shared_state.hpp 1 addition, 1 deletionarbor/backends/multicore/shared_state.hpp
- arbor/fvm_layout.cpp 35 additions, 2 deletionsarbor/fvm_layout.cpp
- arbor/fvm_layout.hpp 1 addition, 1 deletionarbor/fvm_layout.hpp
- arbor/fvm_lowered_cell_impl.hpp 1 addition, 1 deletionarbor/fvm_lowered_cell_impl.hpp
- arbor/include/arbor/mechinfo.hpp 8 additions, 0 deletionsarbor/include/arbor/mechinfo.hpp
- mechanisms/mod/test_ca.mod 1 addition, 1 deletionmechanisms/mod/test_ca.mod
- modcc/blocks.hpp 11 additions, 1 deletionmodcc/blocks.hpp
- modcc/identifier.hpp 1 addition, 0 deletionsmodcc/identifier.hpp
- modcc/module.cpp 6 additions, 0 deletionsmodcc/module.cpp
- modcc/parser.cpp 36 additions, 3 deletionsmodcc/parser.cpp
- modcc/parser.hpp 1 addition, 0 deletionsmodcc/parser.hpp
Please register or sign in to comment