Skip to content
Snippets Groups Projects
Select Git revision
  • fdd9e7eee2ff3446871540768d582fa53ebf0ee3
  • master default protected
  • tut_ring_allen
  • docs_furo
  • docs_reorder_cable_cell
  • docs_graphviz
  • docs_rtd_dev
  • ebrains_mirror
  • doc_recat
  • docs_spike_source
  • docs_sim_sample_clar
  • docs_pip_warn
  • github_template_updates
  • docs_fix_link
  • cv_default_and_doc_clarification
  • docs_add_numpy_req
  • readme_zenodo_05
  • install_python_fix
  • install_require_numpy
  • typofix_propetries
  • docs_recipe_lookup
  • v0.10.0
  • v0.10.1
  • v0.10.0-rc5
  • v0.10.0-rc4
  • v0.10.0-rc3
  • v0.10.0-rc2
  • v0.10.0-rc
  • v0.9.0
  • v0.9.0-rc
  • v0.8.1
  • v0.8
  • v0.8-rc
  • v0.7
  • v0.6
  • v0.5.2
  • v0.5.1
  • v0.5
  • v0.4
  • v0.3
  • v0.2.2
41 results

expression.cpp

Blame
  • user avatar
    Sam Yates authored and Ben Cumming committed
    Address inconsistencies in unit conversions between current updates, initialization, ionic currents etc.
    
    Fixes issues #793 and #798.
    
    * Correct units in comments for ion state iX_ to a current density.
    * Remove conversion factor for NMODL current densities [mA/cm²] to Arbor current densities [A/m²] from layout weight: from the point of view of Arbor, mechanisms now write in units that Arbor uses natively.
    * Remove weight_ as a magic modcc variable; applying weight_ is now performed directly by code generated by printers.
    * Change IndexedVariable interface: remove redundant index_name; remove 'op'. Whether external data is accumulated or assigned is now a property of the corresponding sourceKind.
    * Conversion factors for NMODL <-> Arbor are collated in printerutils.cpp, determined by the external data sourceKind.
    * Permit direct assignment of external data, as opposed to a weighted sum. This behaviour will be required for reversal potential handling.
    * `current_` and `conducitivity_` get a different sourceKind in point mechanisms, allowing us to distinguish current contributions from current density contributions (and applying correct unit scaling accordingly.)
    * Add unit test for correct initialization and scaling of ionic currents, together with two corresponding unit test mechanisms.
    f9f34ccf
    History
    expression.cpp 34.93 KiB