Skip to content
Snippets Groups Projects

Bug fixing, code and text improving

Merged Didi Hou requested to merge github/fork/didi-hou/Enhance_code_docum into master

Created by: didi-hou

This PR fixed the problem of computing the firing rate over all areas instead of only all simulated areas. Besides, it reorganized the structure of the notebook, and refined plots, texts, and comments.

  • It corrected the bug that the firing rate in plots was computed from all areas, instead now it is computed from only the simulated populations
  • It reorganized the structure of the notebook and enhanced the plots, texts, and comments
  • It removed the unnecessary file VERSION_LOG.md
  • It removed the plot of instantaneous and mean firing rate and added only printing the mean firing rate of all simulated populations

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking

multi-area-model.ipynb

Download
  • Author Owner

    Created by: shimoura

    • Remember to uncomment in section 2.5: M.simulation.simulate()
    • The numbers in section 1.1 are presented in different sizes due to the latex format used for the math signs "$ $". It would be better to normalize all numbers in the table using the same format.
  • Author Owner

    Created by: didi-hou

    Both problems are now fixed

  • Didi Hou
  • Didi Hou
  • Didi Hou
  • Didi Hou
  • Author Owner

    Created by: shimoura

    Review: Changes requested

    All in all looks good, please just correct a few typos and suggestions. As a reminder: there is some cleaning to make and docstring to be added in the visualization functions. It should be solved in future PR after defining what functions will be kept as they are now.

  • Author Owner

    Created by: didi-hou

    Review: Commented

    All suggested improvements are now done.

  • Didi Hou requested review from @didihou

    requested review from @didihou

  • Author Owner

    Created by: shimoura

    Review: Approved

  • Author Owner

    Merged by: shimoura at 2024-02-14 09:45:22 UTC

  • Didi Hou merged manually

    merged manually

  • closed

  • Please register or sign in to reply