From eca7b168ad4e9508ba0ac8bf575269c84b4f9f66 Mon Sep 17 00:00:00 2001 From: Xiao Gui <xgui3783@gmail.com> Date: Tue, 13 Jun 2023 10:34:51 +0200 Subject: [PATCH] fix: unit tests maint: update checklist --- e2e/checklist.md | 14 ++++++++++++++ src/share/saneUrl/saneUrl.component.spec.ts | 3 ++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/e2e/checklist.md b/e2e/checklist.md index 50e2c7125..5e740efa8 100644 --- a/e2e/checklist.md +++ b/e2e/checklist.md @@ -48,6 +48,20 @@ - [ ] v4 are visible - [ ] on hover, show correct region name(s) - [ ] whole mesh loads + +## Pt Assignments + +- [ ] human MNI152 julich brain should work (statistical) +- [ ] rat waxholm v4 should work (labelled) +- [ ] csv can be downloaded +- [ ] big brain & fsaverage *shouldn't* work + +## Download atlas + +- [ ] human MNI152 julich brain can be downloaded +- [ ] human MNI152 julich brain hoc1 left can be downloaded +- [ ] rat waxholm v4 can be downloaded + ## saneURL - [ ] saneurl generation functions properly - [ ] try existing key (human), and get unavailable error diff --git a/src/share/saneUrl/saneUrl.component.spec.ts b/src/share/saneUrl/saneUrl.component.spec.ts index 982ecb76f..967039d1d 100644 --- a/src/share/saneUrl/saneUrl.component.spec.ts +++ b/src/share/saneUrl/saneUrl.component.spec.ts @@ -1,13 +1,13 @@ import { TestBed, fakeAsync, tick, flush, ComponentFixture } from '@angular/core/testing' import { SaneUrl } from './saneUrl.component' import { By } from '@angular/platform-browser' -import { BACKENDURL } from 'src/util/constants' import { NoopAnimationsModule } from '@angular/platform-browser/animations' import { SaneUrlSvc } from './saneUrl.service' import { AngularMaterialModule } from 'src/sharedModules' import { CUSTOM_ELEMENTS_SCHEMA, Directive } from '@angular/core' import { of, throwError } from 'rxjs' import { NotFoundError } from '../type' +import { FormsModule } from '@angular/forms' const inputCss = `input[aria-label="Custom link"]` const submitCss = `button[aria-label="Create custom link"]` @@ -34,6 +34,7 @@ describe('> saneUrl.component.ts', () => { imports: [ NoopAnimationsModule, AngularMaterialModule, + FormsModule, ], providers: [ { -- GitLab