From a38ebfca0f829820e4818c9ac897cd768c0a5161 Mon Sep 17 00:00:00 2001
From: Xiao Gui <xgui3783@gmail.com>
Date: Tue, 19 Sep 2023 10:51:34 +0200
Subject: [PATCH] fix: disposer incorrectly fires
---
src/atlasComponents/annotations/annotation.service.ts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/atlasComponents/annotations/annotation.service.ts b/src/atlasComponents/annotations/annotation.service.ts
index fd19915d2..776fb7848 100644
--- a/src/atlasComponents/annotations/annotation.service.ts
+++ b/src/atlasComponents/annotations/annotation.service.ts
@@ -110,9 +110,10 @@ export class AnnotationLayer {
this._onHover.next(payload)
})
this.onDestroyCb.push(res)
-
+
this.nglayer.layer.registerDisposer(() => {
- this.dispose()
+ // TODO registerdisposer seems to fire without the layer been removed
+ // Thus it cannot be relied upon for cleanup
})
NehubaLayerControlService.RegisterLayerName(this.name)
}
--
GitLab