From 7a8eed295d0321e339ab6a40b2ece0ba497ba265 Mon Sep 17 00:00:00 2001 From: Xiao Gui <xgui3783@gmail.com> Date: Wed, 2 Oct 2019 12:06:36 +0200 Subject: [PATCH] chore: remove unused fn bugfix: charts --- src/ui/databrowserModule/fileviewer/chart/chart.base.ts | 5 +++-- .../fileviewer/chart/line/line.chart.component.ts | 4 ---- .../fileviewer/chart/line/line.chart.style.css | 4 ++++ .../fileviewer/chart/radar/radar.chart.style.css | 4 ++++ 4 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/ui/databrowserModule/fileviewer/chart/chart.base.ts b/src/ui/databrowserModule/fileviewer/chart/chart.base.ts index fdc61a3bb..98d736d35 100644 --- a/src/ui/databrowserModule/fileviewer/chart/chart.base.ts +++ b/src/ui/databrowserModule/fileviewer/chart/chart.base.ts @@ -38,12 +38,13 @@ export class ChartBase{ interval(500).pipe( map(() => this.canvas && this.canvas.nativeElement), filter(v => !!v), - take(1), switchMap(el => from( new Promise(rs => el.toBlob(blob => rs(blob), 'image/png')) ) as Observable<Blob> - ) + ), + filter(v => !!v), + take(1) ) ), map(blob => { diff --git a/src/ui/databrowserModule/fileviewer/chart/line/line.chart.component.ts b/src/ui/databrowserModule/fileviewer/chart/line/line.chart.component.ts index 4defd73c0..15b387dd8 100644 --- a/src/ui/databrowserModule/fileviewer/chart/line/line.chart.component.ts +++ b/src/ui/databrowserModule/fileviewer/chart/line/line.chart.component.ts @@ -111,10 +111,6 @@ export class LineChart extends ChartBase implements OnChanges, CommonChartInterf super(sanitizer) } - ngOnInit(){ - this.pngUrl$.subscribe(console.log) - } - ngOnChanges(){ this.shapedLineChartDatasets = this.lineDatasets.map(lineDataset=>({ data: lineDataset.data.map((v,idx)=>({ diff --git a/src/ui/databrowserModule/fileviewer/chart/line/line.chart.style.css b/src/ui/databrowserModule/fileviewer/chart/line/line.chart.style.css index e69de29bb..7575b8e32 100644 --- a/src/ui/databrowserModule/fileviewer/chart/line/line.chart.style.css +++ b/src/ui/databrowserModule/fileviewer/chart/line/line.chart.style.css @@ -0,0 +1,4 @@ +:host +{ + display: block; +} diff --git a/src/ui/databrowserModule/fileviewer/chart/radar/radar.chart.style.css b/src/ui/databrowserModule/fileviewer/chart/radar/radar.chart.style.css index e69de29bb..7575b8e32 100644 --- a/src/ui/databrowserModule/fileviewer/chart/radar/radar.chart.style.css +++ b/src/ui/databrowserModule/fileviewer/chart/radar/radar.chart.style.css @@ -0,0 +1,4 @@ +:host +{ + display: block; +} -- GitLab