diff --git a/docs/releases/v2.3.5.md b/docs/releases/v2.3.5.md new file mode 100644 index 0000000000000000000000000000000000000000..27726fea2b27cf12bc6c08cf36fbe86633878b0e --- /dev/null +++ b/docs/releases/v2.3.5.md @@ -0,0 +1,5 @@ +# v2.3.5 + +## Under the hood stuff + +- Temporarily disable Colin 27 template. \ No newline at end of file diff --git a/src/res/ext/atlas/atlas_multiLevelHuman.json b/src/res/ext/atlas/atlas_multiLevelHuman.json index 36d9d008da84e634321e63595bf02760502602ac..be3f3b7f101672bf28ac682ba4746f11518453de 100644 --- a/src/res/ext/atlas/atlas_multiLevelHuman.json +++ b/src/res/ext/atlas/atlas_multiLevelHuman.json @@ -51,20 +51,6 @@ } ] }, - { - "@id": "minds/core/referencespace/v1.0.0/7f39f7be-445b-47c0-9791-e971c0b6d992", - "name": "MNI Colin 27", - "availableIn": [ - { - "@id": "minds/core/parcellationatlas/v1.0.0/94c1125b-b87e-45e4-901c-00daee7f2579-25", - "name": "Cytoarchitectonic maps - v2.5" - }, - { - "@id": "juelich/iav/atlas/v1.0.0/8", - "name": "Cytoarchitectonic Maps - v1.18" - } - ] - }, { "@id": "minds/core/referencespace/v1.0.0/a1655b99-82f1-420f-a3c2-fe80fd4c8588", "name": "Big Brain (Histology)", @@ -102,13 +88,6 @@ "originalDatasetFormats": [{ "name": "probability map" }] - }, - { - "@id": "minds/core/referencespace/v1.0.0/7f39f7be-445b-47c0-9791-e971c0b6d992", - "name": "MNI Colin 27", - "originalDatasetFormats": [{ - "name": "probability map" - }] } ] }, @@ -146,13 +125,6 @@ "originalDatasetFormats": [{ "name": "probability map" }] - }, - { - "@id": "minds/core/referencespace/v1.0.0/7f39f7be-445b-47c0-9791-e971c0b6d992", - "name": "MNI Colin 27", - "originalDatasetFormats": [{ - "name": "probability map" - }] } ] }, diff --git a/src/ui/parcellationRegion/region.base.ts b/src/ui/parcellationRegion/region.base.ts index 56742360d9194d228b1eda8c529373d48a190fe6..0897a5f0cb93d9cc79c32fbc2cdad5f2745ba593 100644 --- a/src/ui/parcellationRegion/region.base.ts +++ b/src/ui/parcellationRegion/region.base.ts @@ -257,9 +257,11 @@ export class RenderViewOriginDatasetLabelPipe implements PipeTransform{ } export const regionInOtherTemplateSelector = createSelector( + viewerStateGetSelectedAtlas, viewerStateFetchedTemplatesSelector, viewerStateSelectedTemplateSelector, - (fetchedTemplates, templateSelected, prop) => { + (atlas, fetchedTemplates, templateSelected, prop) => { + const atlasTemplateSpacesIds = atlas.templateSpaces.map(({ ['@id']: id }) => id) const { region: regionOfInterest } = prop const returnArr = [] @@ -268,7 +270,13 @@ export const regionInOtherTemplateSelector = createSelector( const regionOfInterestId = getIdFromFullId(regionOfInterest.fullId) if (!templateSelected) return [] const selectedTemplateId = getIdFromFullId(templateSelected.fullId) - const otherTemplates = fetchedTemplates.filter(({ fullId }) => getIdFromFullId(fullId) !== selectedTemplateId) + + // need to ensure that the templates are defined in atlas definition + // atlas is the single source of truth + + const otherTemplates = fetchedTemplates + .filter(({ fullId }) => getIdFromFullId(fullId) !== selectedTemplateId) + .filter(({ ['@id']: id }) => atlasTemplateSpacesIds.includes(id)) for (const template of otherTemplates) { for (const parcellation of template.parcellations) { const flattenedRegions = flattenRegions(parcellation.regions)