From 5484e5d234eaa3567553723cb99cee07ae95b090 Mon Sep 17 00:00:00 2001
From: Xiao Gui <xgui3783@gmail.com>
Date: Fri, 26 May 2023 15:02:22 +0200
Subject: [PATCH] fix: CI pipeline & checklist
---
.github/workflows/release.yml | 2 +-
e2e/checklist.md | 12 +-----------
2 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 9f582522c..d42084c9c 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -32,7 +32,7 @@ jobs:
with:
tag_name: ${{ needs.check-version.outputs.package-version }}
release_name: Release ${{ needs.check-version.outputs.package-version }}
- body_path: docs/releases/v${{ needs.check-version.outputs.package-version }}.md
+ body_path: docs/releases/${{ needs.check-version.outputs.package-version }}.md
draft: false
prerelease: false
diff --git a/e2e/checklist.md b/e2e/checklist.md
index 51e3e9e1f..50e2c7125 100644
--- a/e2e/checklist.md
+++ b/e2e/checklist.md
@@ -31,16 +31,6 @@
- [ ] `Preview` tab exists and works
- [ ] fingerprint is shown, interactable
- [ ] profiles can be loaded, interactable
- - [ ] GDPR warning triangle
- - [ ] `Open in KG` button exists and works
- - [ ] perspective view works
- - [ ] mesh becomes transparent
- - [ ] mesh transparency returns when exit the panel
- - [ ] electrodes appear in perspective view
- - [ ] some contact points should apepar red (intersect with region)
- - [ ] electrode tab
- - [ ] show should a number of contact points
- - [ ] clicking on electrode should navigate to the contact point location
- [ ] `Connectivity` tab exists and works
- [ ] on opening tab, PMap disappear, colour mapped segmentation appears
- [ ] on closing tab, PMap reappear, segmentation hides
@@ -62,7 +52,7 @@
- [ ] saneurl generation functions properly
- [ ] try existing key (human), and get unavailable error
- [ ] try non existing key, and get available
- - [ ] create use key `x-tmp-foo` and new url works
+ - [ ] create use key `x_tmp_foo` and new url works
- [ ] [saneUrl](https://atlases.ebrains.eu/viewer-staging/saneUrl/bigbrainGreyWhite) redirects to big brain
- [ ] [saneUrl](https://atlases.ebrains.eu/viewer-staging/saneUrl/julichbrain) redirects to julich brain (colin 27)
- [ ] [saneUrl](https://atlases.ebrains.eu/viewer-staging/saneUrl/whs4) redirects to waxholm v4
--
GitLab