From 04e6cef7cb6db22c9b4cc7afeacc6885fc0fa4f1 Mon Sep 17 00:00:00 2001
From: Xiao Gui <xgui3783@gmail.com>
Date: Wed, 5 Jul 2023 13:20:45 +0200
Subject: [PATCH] bugfix: on hover region label now display properly
---
docs/releases/v2.12.2.md | 1 +
.../threeSurfer/threeSurferGlue/threeSurfer.component.ts | 4 ----
src/viewerModule/viewerCmp/viewerCmp.component.ts | 8 ++++++++
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/docs/releases/v2.12.2.md b/docs/releases/v2.12.2.md
index 7cc249830..460f1ad34 100644
--- a/docs/releases/v2.12.2.md
+++ b/docs/releases/v2.12.2.md
@@ -3,3 +3,4 @@
## Bugfixes
- fixes screenshot in fsaverage
+- on hover region label in fsaverage now display properly
diff --git a/src/viewerModule/threeSurfer/threeSurferGlue/threeSurfer.component.ts b/src/viewerModule/threeSurfer/threeSurferGlue/threeSurfer.component.ts
index 4af773b7b..275b12b73 100644
--- a/src/viewerModule/threeSurfer/threeSurferGlue/threeSurfer.component.ts
+++ b/src/viewerModule/threeSurfer/threeSurferGlue/threeSurfer.component.ts
@@ -906,13 +906,9 @@ export class ThreeSurferGlueCmp implements IViewer<'threeSurfer'>, AfterViewInit
}
})
this.mouseoverText = ''
- if (mouseover.length > 0) {
- this.mouseoverText += mouseover.map(el => el.name).join(' / ')
- }
if (error) {
this.mouseoverText += `::error: ${error}`
}
- if (this.mouseoverText === '') this.mouseoverText = null
}
public toggleMeshVis(label: string) {
diff --git a/src/viewerModule/viewerCmp/viewerCmp.component.ts b/src/viewerModule/viewerCmp/viewerCmp.component.ts
index b0d53ca11..75f18fd1e 100644
--- a/src/viewerModule/viewerCmp/viewerCmp.component.ts
+++ b/src/viewerModule/viewerCmp/viewerCmp.component.ts
@@ -405,6 +405,14 @@ export class ViewerCmp implements OnDestroy {
)
}
}
+ if (event.data.viewerType === "threeSurfer") {
+ const { regions=[] } = (event.data as TContextArg<"threeSurfer">).payload
+ this.store$.dispatch(
+ userInteraction.actions.mouseoverRegions({
+ regions: regions as SxplrRegion[]
+ })
+ )
+ }
break
default:
}
--
GitLab