diff --git a/docs/releases/v2.5.5.md b/docs/releases/v2.5.5.md index 07b2304906612518206a5867da7c8c6997592756..cc33173305d0da142c2bf34b94b9926e1e123be1 100644 --- a/docs/releases/v2.5.5.md +++ b/docs/releases/v2.5.5.md @@ -1,4 +1,4 @@ -# v2.5.4 +# v2.5.5 ## Feature @@ -7,3 +7,4 @@ ## Under the hood - Temporarily use up-to-date endpoint for MEBRAINS +- Add fsaverage to checklist diff --git a/e2e/checklist.md b/e2e/checklist.md index 7577819cb3cf150a1fc8588a165c9224b57290c0..fbe5c5240c08d8f8a88760a51d278bb0325dc2b5 100644 --- a/e2e/checklist.md +++ b/e2e/checklist.md @@ -46,6 +46,11 @@ - [ ] the navigation should be preserved - [ ] in big brain v2.9 (or latest) - [ ] high res hoc1, hoc2, hoc3, lam1-6 are visible + - [ ] pli dataset [link](https://siibra-explorer.apps.hbp.eu/staging/?templateSelected=Big+Brain+%28Histology%29&parcellationSelected=Grey%2FWhite+matter&cNavigation=0.0.0.-W000.._eCwg.2-FUe3._-s_W.2_evlu..7LIx..1uaTK.Bq5o~.lKmo~..NBW&previewingDatasetFiles=%5B%7B%22datasetId%22%3A%22minds%2Fcore%2Fdataset%2Fv1.0.0%2Fb08a7dbc-7c75-4ce7-905b-690b2b1e8957%22%2C%22filename%22%3A%22Overlay+of+data+modalities%22%7D%5D) + - [ ] redirects fine + - [ ] shows fine + - [ ] fsaverage + - [ ] can be loaded & visible - [ ] Waxholm - [ ] v4 are visible - [ ] on hover, show correct region name(s) \ No newline at end of file diff --git a/src/util/pureConstant.service.ts b/src/util/pureConstant.service.ts index d2bfeae7e4c0ff88e748acf2af2d751a8f8c23b9..260f4a856390b0b4883fa3a9fcf44cbbd7109fa6 100644 --- a/src/util/pureConstant.service.ts +++ b/src/util/pureConstant.service.ts @@ -577,25 +577,6 @@ Raise/track issues at github repo: <a target = "_blank" href = "${this.repoUrl}" ? 'right hemisphere' : 'whole brain' - /** - * TODO fix in siibra-api - */ - if ( - tmpl.id !== 'minds/core/referencespace/v1.0.0/a1655b99-82f1-420f-a3c2-fe80fd4c8588' - && parc.id === 'minds/core/parcellationatlas/v1.0.0/94c1125b-b87e-45e4-901c-00daee7f2579-290' - && hemisphereKey === 'whole brain' - ) { - region.labelIndex = null - return - } - - if ( - tmpl.id === 'minds/core/referencespace/v1.0.0/a1655b99-82f1-420f-a3c2-fe80fd4c8588' - && parc.id === 'minds/core/parcellationatlas/v1.0.0/94c1125b-b87e-45e4-901c-00daee7f2579-290' - && hemisphereKey === 'whole brain' - ) { - region.children = [] - } if (!region['ngId']) { const hemispheredNgId = getNgId(atlas['@id'], tmpl.id, parc.id, hemisphereKey) region['ngId'] = hemispheredNgId @@ -751,7 +732,7 @@ Raise/track issues at github repo: <a target = "_blank" href = "${this.repoUrl}" const precomputedArr = tmpl._dataset_specs.filter(src => src['@type'] === 'fzj/tmp/volume_type/v0.0.1' && src.volume_type === 'neuroglancer/precomputed') as TVolumeSrc<'neuroglancer/precomputed'>[] let visible = true let tmplNgId: string - let templateImages: TTemplateImage[] = [] + const templateImages: TTemplateImage[] = [] for (const precomputedItem of precomputedArr) { const ngIdKey = MultiDimMap.GetKey(precomputedItem["@id"]) const precomputedUrl = 'https://neuroglancer.humanbrainproject.eu/precomputed/data-repo-ng-bot/20211001-mebrain/precomputed/images/MEBRAINS_T1.masked' === precomputedItem.url diff --git a/src/viewerModule/viewerCmp/viewerCmp.component.ts b/src/viewerModule/viewerCmp/viewerCmp.component.ts index 2ecb19f5f4e07649d61039fc88bcbd84b9a9045d..27c6eac25d510299e06a38c8e5be1814acb3d8c7 100644 --- a/src/viewerModule/viewerCmp/viewerCmp.component.ts +++ b/src/viewerModule/viewerCmp/viewerCmp.component.ts @@ -308,6 +308,7 @@ export class ViewerCmp implements OnDestroy { markdown: message.join('\n\n'), confirmOnly: true }) + // eslint-disable-next-line @typescript-eslint/no-empty } catch (e) { }