From 8b057f400279c4e7004a4319ef4df12c167ab864 Mon Sep 17 00:00:00 2001
From: Xiao Gui <xgui3783@gmail.com>
Date: Wed, 21 Jun 2023 10:35:59 +0200
Subject: [PATCH] added maintainers, added test

---
 packages/py-neuroglancer-scripts/package.py |  5 +++--
 packages/py-siibra/package.py               | 12 ++++++++++--
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/packages/py-neuroglancer-scripts/package.py b/packages/py-neuroglancer-scripts/package.py
index 5d2c560f..a2604f78 100644
--- a/packages/py-neuroglancer-scripts/package.py
+++ b/packages/py-neuroglancer-scripts/package.py
@@ -7,8 +7,7 @@ class PyNeuroglancerScripts(PythonPackage):
     homepage = "https://github.com/HumanBrainProject/neuroglancer-scripts"
     pypi     = "neuroglancer-scripts/neuroglancer-scripts-1.1.0.tar.gz"
 
-    # TODO
-    # maintainers = ['username']
+    maintainers = ['Yann Leprince']
 
     version('1.1.0',    sha256='395a3565808136950a1e3296b43eeda13a0108d2286eba2b2924b33c3b3abc70')
     version('1.0.0',    sha256='524c0e3a3faebaf3952953f8097af347655bed3e70b3a4bc4043a6f216db7d28')
@@ -24,4 +23,6 @@ class PyNeuroglancerScripts(PythonPackage):
     depends_on('py-requests',     type=('build', 'run'))
     depends_on('py-scikit-image', type=('build', 'run'))
     depends_on('py-tqdm',         type=('build', 'run'))
+
+    # Not needed for the purpose siibra-python
     # depends_on('py-imagecodecs',  type=('build', 'run')) # TODO: had some issues
diff --git a/packages/py-siibra/package.py b/packages/py-siibra/package.py
index b3f2df92..5b6c3138 100644
--- a/packages/py-siibra/package.py
+++ b/packages/py-siibra/package.py
@@ -7,8 +7,7 @@ class PySiibra(PythonPackage):
     homepage = "https://github.com/FZJ-INM1-BDA/siibra-python"
     pypi     = "siibra/siibra-0.4a57.tar.gz"
 
-    # TODO
-    # maintainers = ['username']
+    maintainers = ['x.gui@fz-juelich.de', 's.koehnen@fz-juelich.de', 't.dickscheid@fz-juelich.de']
 
     version("0.4a57", sha256="53983c4baab84abe5dd6928c320ce87433cab02b5ed992995f0a17661c93dbff")
     version("0.4a56", sha256="4c03d8a94c73a233e216103fa7090d057db03b1806027fabde38e8f83b852d78")
@@ -32,3 +31,12 @@ class PySiibra(PythonPackage):
     depends_on('py-nilearn',              type=('build', 'run'))
     depends_on('py-typing-extensions',    type=('build', 'run'), when='^python@:3.7')
     depends_on('py-filelock',             type=('build', 'run'))
+
+    depends_on('py-pytest', type='test')
+
+    # @run_after('install')
+    # @on_package_attributes(run_tests=True)
+    # def install_test(self): 
+    #     with working_dir('spack-test', create=True):
+    #         pytest("-rx")
+
-- 
GitLab