From 5a067f511989e36a320bf1894f06602222f50767 Mon Sep 17 00:00:00 2001
From: ManosAngelidis <angelidis@fortiss.org>
Date: Tue, 1 Jun 2021 12:03:03 +0200
Subject: [PATCH] [NRRPLT-8625] eslint and moving the test to the right folder
---
.../__tests__/models-storage-service.test.js | 26 +++++++++----------
src/services/models/models-storage-service.js | 1 -
2 files changed, 13 insertions(+), 14 deletions(-)
rename src/services/{ => models}/__tests__/models-storage-service.test.js (75%)
diff --git a/src/services/__tests__/models-storage-service.test.js b/src/services/models/__tests__/models-storage-service.test.js
similarity index 75%
rename from src/services/__tests__/models-storage-service.test.js
rename to src/services/models/__tests__/models-storage-service.test.js
index 94603b8..411d908 100644
--- a/src/services/__tests__/models-storage-service.test.js
+++ b/src/services/models/__tests__/models-storage-service.test.js
@@ -4,7 +4,7 @@
import '@testing-library/jest-dom';
import 'jest-fetch-mock';
-import ModelsStorageService from '../models/models-storage-service';
+import ModelsStorageService from '../models-storage-service'
test('makes sure that invoking the constructor fails with the right message', () => {
expect(() => {
@@ -23,24 +23,24 @@ test('the service instance always refers to the same object', () => {
test('getTemplateModels function', async () => {
-
+
let modelsService = ModelsStorageService.instance;
// fetch template robots
- let response = await modelsService.getTemplateModels(true,'robots',false);
+ let response = await modelsService.getTemplateModels(true, 'robots', false);
expect(response.name).toBe('hbp_clearpath_robotics_husky_a200');
expect(response.ownerName).toBe('nrpuser');
expect(response.type).toBe('robots');
// fetch custom robots
- response = await modelsService.getTemplateModels(true,'robots',true);
+ response = await modelsService.getTemplateModels(true, 'robots', true);
expect(response.name).toBe('custom_hbp_clearpath_robotics_husky_a200');
expect(response.ownerName).toBe('nrpuser');
- expect(response.type).toBe('robots');
+ expect(response.type).toBe('robots');
});
test('getCustomModelsByUser function', async () => {
-
+
let modelsService = ModelsStorageService.instance;
// fetch template robots
@@ -52,19 +52,19 @@ test('getCustomModelsByUser function', async () => {
});
test('verifyModelType function', async () => {
-
+
let modelsService = ModelsStorageService.instance;
- const expectedErrorPart = 'Error Type 400: Bad Request : The model type notRobots';
+ const expectedErrorPart = 'Error Type 400: Bad Request : The model type notRobots';
// fetch template robots
- expect(()=>modelsService.verifyModelType('notRobots')).toThrowError(expectedErrorPart);
-
+ expect(() => modelsService.verifyModelType('notRobots')).toThrowError(expectedErrorPart);
+
});
test('setCustomModel function', async () => {
let modelsService = ModelsStorageService.instance;
-
- let response = await modelsService.setCustomModel('robots','husky','fakeContent');
+
+ let response = await modelsService.setCustomModel('robots', 'husky', 'fakeContent');
expect(response.name).toBe('created_hbp_clearpath_robotics_husky_a200');
expect(response.ownerName).toBe('nrpuser');
- expect(response.type).toBe('robots');
+ expect(response.type).toBe('robots');
});
diff --git a/src/services/models/models-storage-service.js b/src/services/models/models-storage-service.js
index 342de10..a75f25c 100644
--- a/src/services/models/models-storage-service.js
+++ b/src/services/models/models-storage-service.js
@@ -133,7 +133,6 @@ class ModelsStorageService extends HttpService {
try {
this.verifyModelType(modelType);
const setCustomModelURL = `${storageModelsURL}/${modelType}/${modelName}`;
- console.log(setCustomModelURL)
return (await this.httpRequestPOST(setCustomModelURL, fileContent)).json();
}
catch (error) {
--
GitLab