From 3da83a9550eaa86e2cb4d02ea5b5b90f17b93fa1 Mon Sep 17 00:00:00 2001
From: Mirco Nasuti <mirco.nasuti@chuv.ch>
Date: Thu, 14 Jul 2016 16:30:43 +0200
Subject: [PATCH] bugfix manage dupplicate titles and slugs

---
 src/main/java/org/hbp/mip/controllers/ArticlesApi.java | 6 ++++--
 src/main/java/org/hbp/mip/controllers/ModelsApi.java   | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/hbp/mip/controllers/ArticlesApi.java b/src/main/java/org/hbp/mip/controllers/ArticlesApi.java
index cc8cd14d2..d08a76e0c 100644
--- a/src/main/java/org/hbp/mip/controllers/ArticlesApi.java
+++ b/src/main/java/org/hbp/mip/controllers/ArticlesApi.java
@@ -115,9 +115,11 @@ public class ArticlesApi {
         }
 
         i = 0;
+        boolean alreadyExists;
         do {
             i++;
-            if(articleRepository.exists(slug))
+            alreadyExists = articleRepository.exists(slug);
+            if(alreadyExists)
             {
                 if(i > 1)
                 {
@@ -126,7 +128,7 @@ public class ArticlesApi {
                 slug += "-"+i;
             }
             article.setSlug(slug);
-        } while(count > 0);
+        } while(alreadyExists);
         articleRepository.save(article);
 
         return new ResponseEntity<>(HttpStatus.CREATED);
diff --git a/src/main/java/org/hbp/mip/controllers/ModelsApi.java b/src/main/java/org/hbp/mip/controllers/ModelsApi.java
index a3a0afda1..8b87357ce 100644
--- a/src/main/java/org/hbp/mip/controllers/ModelsApi.java
+++ b/src/main/java/org/hbp/mip/controllers/ModelsApi.java
@@ -139,7 +139,7 @@ public class ModelsApi {
         do {
             i++;
             alreadyExists = modelRepository.exists(slug);
-            if(count > 0)
+            if(alreadyExists)
             {
                 if(i > 1)
                 {
-- 
GitLab