From ad26b1144508a5f9331fbcf9d85bdbaf75c7d8a7 Mon Sep 17 00:00:00 2001
From: akuesters <42005107+akuesters@users.noreply.github.com>
Date: Wed, 19 Sep 2018 09:52:08 +0200
Subject: [PATCH] Fixed warnings of signed-unsigned integer comparison in unit
tests
---
test/unit/test_dry_run_context.cpp | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/test/unit/test_dry_run_context.cpp b/test/unit/test_dry_run_context.cpp
index 24752c32..b4c9a6d0 100644
--- a/test/unit/test_dry_run_context.cpp
+++ b/test/unit/test_dry_run_context.cpp
@@ -20,7 +20,7 @@ TEST(dry_run_context, size_rank)
{
distributed_context_handle ctx = arb::make_dry_run_context(num_ranks, num_cells_per_rank);
- EXPECT_EQ(ctx->size(), num_ranks);
+ EXPECT_EQ(ctx->size(), (int)num_ranks);
EXPECT_EQ(ctx->id(), 0);
}
@@ -41,16 +41,19 @@ TEST(dry_run_context, minmax)
int64_t one64 = 1;
EXPECT_EQ(one64, ctx->min(one64));
EXPECT_EQ(one64, ctx->max(one64));
+
+ EXPECT_EQ(1u, ctx->min(1u));
+ EXPECT_EQ(1u, ctx->max(1u));
}
TEST(dry_run_context, sum)
{
distributed_context_handle ctx = arb::make_dry_run_context(num_ranks, num_cells_per_rank);
- EXPECT_EQ(42., ctx->min(42.));
- EXPECT_EQ(42.f, ctx->min(42.));
- EXPECT_EQ(42 * num_ranks, ctx->sum(42));
- EXPECT_EQ(42u, ctx->min(42u));
+ EXPECT_EQ(42. * num_ranks, ctx->sum(42.));
+ EXPECT_EQ(42.f * num_ranks, ctx->sum(42.f));
+ EXPECT_EQ(int(42 * num_ranks), ctx->sum(42));
+ EXPECT_EQ(unsigned(42 * num_ranks), ctx->sum(42u));
}
TEST(dry_run_context, gather_spikes)
--
GitLab