From 8e2c908e374c46079c74a4992d66f2a2f3cfa0e2 Mon Sep 17 00:00:00 2001
From: Nora Abi Akar <nora.abiakar@gmail.com>
Date: Thu, 9 Sep 2021 20:55:16 +0200
Subject: [PATCH] Fix simulation::add_sampler cell_group dispatch (#1654)
* Fielding an add_sampler call while having no probes is not an error.
---
arbor/benchmark_cell_group.cpp | 5 +----
arbor/spike_source_cell_group.cpp | 4 +---
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/arbor/benchmark_cell_group.cpp b/arbor/benchmark_cell_group.cpp
index a2ed5f34..d5692531 100644
--- a/arbor/benchmark_cell_group.cpp
+++ b/arbor/benchmark_cell_group.cpp
@@ -98,9 +98,6 @@ void benchmark_cell_group::add_sampler(sampler_association_handle h,
cell_member_predicate probe_ids,
schedule sched,
sampler_function fn,
- sampling_policy policy)
-{
- throw std::logic_error("A benchmark_cell group doen't support sampling of internal state!");
-}
+ sampling_policy policy) {}
} // namespace arb
diff --git a/arbor/spike_source_cell_group.cpp b/arbor/spike_source_cell_group.cpp
index 0b61bdb9..ee3be61b 100644
--- a/arbor/spike_source_cell_group.cpp
+++ b/arbor/spike_source_cell_group.cpp
@@ -74,9 +74,7 @@ void spike_source_cell_group::clear_spikes() {
spikes_.clear();
}
-void spike_source_cell_group::add_sampler(sampler_association_handle, cell_member_predicate, schedule, sampler_function, sampling_policy) {
- throw std::logic_error("A spike_source_cell group doen't support sampling of internal state!");
-}
+void spike_source_cell_group::add_sampler(sampler_association_handle, cell_member_predicate, schedule, sampler_function, sampling_policy) {}
} // namespace arb
--
GitLab